Support "use workflow" serialization for Sandbox and Command#72
Open
Support "use workflow" serialization for Sandbox and Command#72
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Schniz
reviewed
Mar 1, 2026
Schniz
approved these changes
Mar 1, 2026
|
See also #58 (cc @TooTallNate ) |
pranaygp
reviewed
Mar 1, 2026
Comment on lines
+159
to
+162
| setSandboxCredentials({ | ||
| token: process.env.VERCEL_TOKEN!, | ||
| teamId: process.env.VERCEL_TEAM_ID!, | ||
| }); |
There was a problem hiding this comment.
Is there a way we can avoid having the user do this? the deserialization should be able to reconstruct the credentials each time, the same way we do in non-workflow context
now that we have e2e encryption in workflow, we can also serialize and pass credentials across the wire if that's a limitation
Collaborator
There was a problem hiding this comment.
yeah that what bothers me the most. but if you use OIDC or any short-term token it might not be good enough
Does *not* add `"use step"` anywhere, so users will have to do this themselves. It could be done, but it is hard to reconzile with the use of AbortSignals and also won't be very useful in practice. Introduces `Sandbox.setCredentials` to allow creating APIClient from serialized values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does not add
"use step"anywhere, so users will have to do this themselves. It could be done, but it is hard to reconzile with the use of AbortSignals and also won't be very useful in practice.Introduces
Sandbox.setCredentialsto allow creating APIClient from serialized values.