Codestin Search App

TooTallNate · 2026-01-26T22:20:57Z

Added automatic discovery for custom classes with workflow serialization, allowing serialization classes to be defined in separate files without requiring explicit directives.

What changed?

Added detection for files containing custom class serialization patterns:
- Files importing from @workflow/serde
- Files using Symbol.for('workflow-serialize') or Symbol.for('workflow-deserialize')
Created shared utilities in transform-utils.ts for consistent pattern detection across all build tools
Updated Next.js, Nitro, Rollup, and Vite plugins to use the new detection patterns
Added exclusion logic to prevent re-processing of generated workflow files
Added tests to verify the pattern detection works correctly
Updated documentation in the SWC plugin spec to explain the new discovery mechanism

How to test?

Create a class with custom serialization in a separate file:

// models/point.js
export class Point {
  constructor(x, y) {
    this.x = x;
    this.y = y;
  }

  static [Symbol.for('workflow-serialize')](instance) {
    return { x: instance.x, y: instance.y };
  }

  static [Symbol.for('workflow-deserialize')](data) {
    return new Point(data.x, data.y);
  }
}

Import and use this class in a workflow or step file:

'use workflow';
import { Point } from '../models/point';

export function myWorkflow() {
  const point = new Point(10, 20);
  return point;
}

Verify the class is properly serialized when passed between client and server

Why make this change?

Previously, files containing custom serialization classes needed to include a 'use step' directive to be discovered and transformed, even if they weren't actual step functions. This was unintuitive and could lead to confusion.

This change allows for a more natural code organization pattern where model classes with serialization can be defined in their own files without requiring directives. The build system will automatically discover and transform these files to ensure the serialization works correctly when the classes are used in workflows or steps.

changeset-bot · 2026-01-26T22:21:01Z

🦋 Changeset detected

Latest commit: 14a46e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@workflow/swc-plugin	Patch
@workflow/builders	Patch
@workflow/rollup	Patch
@workflow/next	Patch
@workflow/astro	Patch
@workflow/cli	Patch
@workflow/nest	Patch
@workflow/nitro	Patch
@workflow/sveltekit	Patch
@workflow/vite	Patch
workflow	Patch
@workflow/docs-typecheck	Patch
@workflow/world-testing	Patch
@workflow/example-nest	Patch
@workflow/nuxt	Patch
@workflow/ai	Patch
@workflow/core	Patch
@workflow/web-shared	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-01-26T22:21:06Z

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

World	Framework	Workflow Time	Wall Time	Overhead	Samples	vs Fastest
💻 Local	🥇 Express	0.042s (-4.7%)	1.007s (~)	0.965s	10	1.00x
🐘 Postgres	Express	0.315s (+9.2% 🔺)	1.013s (~)	0.698s	10	7.47x

▲ Production (Vercel)

World	Framework	Workflow Time	Wall Time	Overhead	Samples	vs Fastest
▲ Vercel	🥇 Express	0.649s (-16.1% 🟢)	1.534s (-5.8% 🟢)	0.884s	10	1.00x

🔍 Observability: Express

workflow with 1 step

💻 Local Development

World	Framework	Workflow Time	Wall Time	Overhead	Samples	vs Fastest
💻 Local	🥇 Express	1.115s (~)	2.007s (~)	0.892s	10	1.00x
🐘 Postgres	Express	2.171s (+2.4%)	3.014s (~)	0.843s	10	1.95x

▲ Production (Vercel)

World	Framework	Workflow Time	Wall Time	Overhead	Samples	vs Fastest
▲ Vercel	🥇 Express	3.035s (+3.7%)	3.767s (+2.7%)	0.732s	10	1.00x

🔍 Observability: Express

workflow with 10 sequential steps

💻 Local Development

World	Framework	Workflow Time	Wall Time	Overhead	Samples	vs Fastest
💻 Local	🥇 Express	10.835s (~)	11.016s (~)	0.181s	5	1.00x
🐘 Postgres	Express	20.411s (~)	21.033s (~)	0.622s	5	1.88x

▲ Production (Vercel)

World	Framework	Workflow Time	Wall Time	Overhead	Samples	vs Fastest
▲ Vercel	🥇 Express	23.095s (-3.8%)	24.115s (-2.4%)	1.020s	5	1.00x

🔍 Observability: Express

Promise.all with 10 concurrent steps

💻 Local Development

World	Framework	Workflow Time	Wall Time	Overhead	Samples	vs Fastest
💻 Local	🥇 Express	5.179s (-5.3% 🟢)	5.432s (-15.7% 🟢)	0.253s	6	1.00x
🐘 Postgres	Express	28.910s (+3.3%)	29.662s (+5.1% 🔺)	0.752s	2	5.58x

▲ Production (Vercel)

World	Framework	Workflow Time	Wall Time	Overhead	Samples	vs Fastest
▲ Vercel	🥇 Express	3.296s (-8.0% 🟢)	3.764s (-5.3% 🟢)	0.468s	8	1.00x

🔍 Observability: Express

Promise.all with 25 concurrent steps

💻 Local Development

World	Framework	Workflow Time	Wall Time	Overhead	Samples	vs Fastest
💻 Local	🥇 Express	5.155s (-2.9%)	6.012s (-4.3%)	0.857s	6	1.00x
🐘 Postgres	Express	31.548s (-6.2% 🟢)	32.098s (-5.9% 🟢)	0.550s	1	6.12x

▲ Production (Vercel)

World	Framework	Workflow Time	Wall Time	Overhead	Samples	vs Fastest
▲ Vercel	🥇 Express	3.223s (-3.4%)	3.802s (-4.9%)	0.579s	8	1.00x

🔍 Observability: Express

Promise.race with 10 concurrent steps

💻 Local Development

World	Framework	Workflow Time	Wall Time	Overhead	Samples	vs Fastest
💻 Local	🥇 Express	5.284s (-6.8% 🟢)	6.266s (-4.9%)	0.981s	5	1.00x
🐘 Postgres	Express	34.150s (-1.4%)	35.096s (~)	0.946s	1	6.46x

▲ Production (Vercel)

World	Framework	Workflow Time	Wall Time	Overhead	Samples	vs Fastest
▲ Vercel	🥇 Express	3.122s (-5.7% 🟢)	3.682s (-7.4% 🟢)	0.560s	9	1.00x

🔍 Observability: Express

Promise.race with 25 concurrent steps

💻 Local Development

World	Framework	Workflow Time	Wall Time	Overhead	Samples	vs Fastest
💻 Local	🥇 Express	5.305s (-5.8% 🟢)	6.306s (-4.1%)	1.002s	5	1.00x
🐘 Postgres	Express	34.477s (+13.8% 🔺)	35.152s (+12.1% 🔺)	0.675s	1	6.50x

▲ Production (Vercel)

World	Framework	Workflow Time	Wall Time	Overhead	Samples	vs Fastest
▲ Vercel	🥇 Express	3.443s (+4.4%)	4.067s (+4.5%)	0.624s	8	1.00x

🔍 Observability: Express

Stream Benchmarks (includes TTFB metrics)

workflow with stream

💻 Local Development

World	Framework	Workflow Time	TTFB	Slurp	Wall Time	Overhead	Samples	vs Fastest
💻 Local	🥇 Express	0.183s (-3.4%)	0.993s (~)	0.014s (-4.7%)	1.021s (~)	0.838s	10	1.00x
🐘 Postgres	Express	2.341s (+6.4% 🔺)	2.702s (-5.0%)	0.000s (~)	3.014s (~)	0.673s	10	12.80x

▲ Production (Vercel)

World	Framework	Workflow Time	TTFB	Slurp	Wall Time	Overhead	Samples	vs Fastest
▲ Vercel	🥇 Express	2.976s (-14.3% 🟢)	3.206s (-8.9% 🟢)	1.096s (-6.6% 🟢)	4.826s (-10.7% 🟢)	1.850s	10	1.00x

🔍 Observability: Express

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World	🥇 Fastest Framework	Wins
💻 Local	Express	8/8
🐘 Postgres	Express	8/8
▲ Vercel	Express	8/8

Fastest World by Framework

Winner determined by most benchmark wins

Framework	🥇 Fastest World	Wins
Express	💻 Local	4/8

Column Definitions

Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
Wall Time: Total testbench time (trigger workflow + poll for result)
Overhead: Testbench overhead (Wall Time - Workflow Time)
Samples: Number of benchmark iterations run
vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

💻 Local: In-memory filesystem world (local development)
🐘 Postgres: PostgreSQL database world (local development)
▲ Vercel: Vercel production/preview deployment
🌐 Starter: Community world (local development)
🌐 Turso: Community world (local development)
🌐 MongoDB: Community world (local development)
🌐 Redis: Community world (local development)
🌐 Jazz: Community world (local development)

📋 View full workflow run

github-actions · 2026-01-26T22:21:07Z

🧪 E2E Test Results

❌ Some tests failed

Summary

	Passed	Failed	Skipped	Total
✅ ▲ Vercel Production	457	0	38	495
✅ 💻 Local Development	418	0	32	450
✅ 📦 Local Production	418	0	32	450
✅ 🐘 Local Postgres	418	0	32	450
✅ 🪟 Windows	45	0	0	45
❌ 🌍 Community Worlds	31	161	0	192
✅ 📋 Other	123	0	12	135
Total	1910	161	146	2217

❌ Failed Tests

🌍 Community Worlds (161 failed)

mongodb (40 failed):

addTenWorkflow
addTenWorkflow
should work with react rendering in step
promiseAllWorkflow
promiseRaceWorkflow
promiseAnyWorkflow
readableStreamWorkflow
hookWorkflow
webhookWorkflow
sleepingWorkflow
nullByteWorkflow
workflowAndStepMetadataWorkflow
outputStreamWorkflow
outputStreamInsideStepWorkflow - getWritable() called inside step functions
fetchWorkflow
promiseRaceStressTestWorkflow
error handling error propagation workflow errors nested function calls preserve message and stack trace
error handling error propagation workflow errors cross-file imports preserve message and stack trace
error handling error propagation step errors basic step error preserves message and stack trace
error handling error propagation step errors cross-file step error preserves message and function names in stack
error handling retry behavior regular Error retries until success
error handling retry behavior FatalError fails immediately without retries
error handling retry behavior RetryableError respects custom retryAfter delay
error handling retry behavior maxRetries=0 disables retries
error handling catchability FatalError can be caught and detected with FatalError.is()
hookCleanupTestWorkflow - hook token reuse after workflow completion
concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
closureVariableWorkflow - nested step functions with closure variables
spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
pathsAliasWorkflow - TypeScript path aliases resolve correctly
Calculator.calculate - static workflow method using static step methods from another class
AllInOneService.processNumber - static workflow method using sibling static step methods
ChainableService.processWithThis - static step methods using this to reference the class
thisSerializationWorkflow - step function invoked with .call() and .apply()
customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
pages router addTenWorkflow via pages router
pages router promiseAllWorkflow via pages router
pages router sleepingWorkflow via pages router

redis (40 failed):

addTenWorkflow
addTenWorkflow
should work with react rendering in step
promiseAllWorkflow
promiseRaceWorkflow
promiseAnyWorkflow
readableStreamWorkflow
hookWorkflow
webhookWorkflow
sleepingWorkflow
nullByteWorkflow
workflowAndStepMetadataWorkflow
outputStreamWorkflow
outputStreamInsideStepWorkflow - getWritable() called inside step functions
fetchWorkflow
promiseRaceStressTestWorkflow
error handling error propagation workflow errors nested function calls preserve message and stack trace
error handling error propagation workflow errors cross-file imports preserve message and stack trace
error handling error propagation step errors basic step error preserves message and stack trace
error handling error propagation step errors cross-file step error preserves message and function names in stack
error handling retry behavior regular Error retries until success
error handling retry behavior FatalError fails immediately without retries
error handling retry behavior RetryableError respects custom retryAfter delay
error handling retry behavior maxRetries=0 disables retries
error handling catchability FatalError can be caught and detected with FatalError.is()
hookCleanupTestWorkflow - hook token reuse after workflow completion
concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
closureVariableWorkflow - nested step functions with closure variables
spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
pathsAliasWorkflow - TypeScript path aliases resolve correctly
Calculator.calculate - static workflow method using static step methods from another class
AllInOneService.processNumber - static workflow method using sibling static step methods
ChainableService.processWithThis - static step methods using this to reference the class
thisSerializationWorkflow - step function invoked with .call() and .apply()
customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
pages router addTenWorkflow via pages router
pages router promiseAllWorkflow via pages router
pages router sleepingWorkflow via pages router

starter (41 failed):

addTenWorkflow
addTenWorkflow
should work with react rendering in step
promiseAllWorkflow
promiseRaceWorkflow
promiseAnyWorkflow
readableStreamWorkflow
hookWorkflow
webhookWorkflow
sleepingWorkflow
nullByteWorkflow
workflowAndStepMetadataWorkflow
outputStreamWorkflow
outputStreamInsideStepWorkflow - getWritable() called inside step functions
fetchWorkflow
promiseRaceStressTestWorkflow
error handling error propagation workflow errors nested function calls preserve message and stack trace
error handling error propagation workflow errors cross-file imports preserve message and stack trace
error handling error propagation step errors basic step error preserves message and stack trace
error handling error propagation step errors cross-file step error preserves message and function names in stack
error handling retry behavior regular Error retries until success
error handling retry behavior FatalError fails immediately without retries
error handling retry behavior RetryableError respects custom retryAfter delay
error handling retry behavior maxRetries=0 disables retries
error handling catchability FatalError can be caught and detected with FatalError.is()
hookCleanupTestWorkflow - hook token reuse after workflow completion
concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
closureVariableWorkflow - nested step functions with closure variables
spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
health check (CLI) - workflow health command reports healthy endpoints
pathsAliasWorkflow - TypeScript path aliases resolve correctly
Calculator.calculate - static workflow method using static step methods from another class
AllInOneService.processNumber - static workflow method using sibling static step methods
ChainableService.processWithThis - static step methods using this to reference the class
thisSerializationWorkflow - step function invoked with .call() and .apply()
customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
pages router addTenWorkflow via pages router
pages router promiseAllWorkflow via pages router
pages router sleepingWorkflow via pages router

turso (40 failed):

addTenWorkflow
addTenWorkflow
should work with react rendering in step
promiseAllWorkflow
promiseRaceWorkflow
promiseAnyWorkflow
readableStreamWorkflow
hookWorkflow
webhookWorkflow
sleepingWorkflow
nullByteWorkflow
workflowAndStepMetadataWorkflow
outputStreamWorkflow
outputStreamInsideStepWorkflow - getWritable() called inside step functions
fetchWorkflow
promiseRaceStressTestWorkflow
error handling error propagation workflow errors nested function calls preserve message and stack trace
error handling error propagation workflow errors cross-file imports preserve message and stack trace
error handling error propagation step errors basic step error preserves message and stack trace
error handling error propagation step errors cross-file step error preserves message and function names in stack
error handling retry behavior regular Error retries until success
error handling retry behavior FatalError fails immediately without retries
error handling retry behavior RetryableError respects custom retryAfter delay
error handling retry behavior maxRetries=0 disables retries
error handling catchability FatalError can be caught and detected with FatalError.is()
hookCleanupTestWorkflow - hook token reuse after workflow completion
concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
closureVariableWorkflow - nested step functions with closure variables
spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
pathsAliasWorkflow - TypeScript path aliases resolve correctly
Calculator.calculate - static workflow method using static step methods from another class
AllInOneService.processNumber - static workflow method using sibling static step methods
ChainableService.processWithThis - static step methods using this to reference the class
thisSerializationWorkflow - step function invoked with .call() and .apply()
customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
pages router addTenWorkflow via pages router
pages router promiseAllWorkflow via pages router
pages router sleepingWorkflow via pages router

Details by Category

✅ ▲ Vercel Production

App	Passed	Skipped
✅ astro	41	4
✅ example	41	4
✅ express	41	4
✅ fastify	41	4
✅ hono	41	4
✅ nextjs-turbopack	44	1
✅ nextjs-webpack	44	1
✅ nitro	41	4
✅ nuxt	41	4
✅ sveltekit	41	4
✅ vite	41	4

✅ 💻 Local Development

App	Passed	Skipped
✅ astro-stable	41	4
✅ express-stable	41	4
✅ fastify-stable	41	4
✅ hono-stable	41	4
✅ nextjs-turbopack-stable	45	0
✅ nextjs-webpack-stable	45	0
✅ nitro-stable	41	4
✅ nuxt-stable	41	4
✅ sveltekit-stable	41	4
✅ vite-stable	41	4

✅ 📦 Local Production

App	Passed	Skipped
✅ astro-stable	41	4
✅ express-stable	41	4
✅ fastify-stable	41	4
✅ hono-stable	41	4
✅ nextjs-turbopack-stable	45	0
✅ nextjs-webpack-stable	45	0
✅ nitro-stable	41	4
✅ nuxt-stable	41	4
✅ sveltekit-stable	41	4
✅ vite-stable	41	4

✅ 🐘 Local Postgres

App	Passed	Skipped
✅ astro-stable	41	4
✅ express-stable	41	4
✅ fastify-stable	41	4
✅ hono-stable	41	4
✅ nextjs-turbopack-stable	45	0
✅ nextjs-webpack-stable	45	0
✅ nitro-stable	41	4
✅ nuxt-stable	41	4
✅ sveltekit-stable	41	4
✅ vite-stable	41	4

✅ 🪟 Windows

App	Passed	Failed	Skipped
✅ nextjs-turbopack	45	0	0

❌ 🌍 Community Worlds

App	Passed	Failed
✅ mongodb-dev	3	0
❌ mongodb	5	40
✅ redis-dev	3	0
❌ redis	5	40
✅ starter-dev	3	0
❌ starter	4	41
✅ turso-dev	3	0
❌ turso	5	40

✅ 📋 Other

App	Passed	Skipped
✅ e2e-local-dev-nest-stable	41	4
✅ e2e-local-postgres-nest-stable	41	4
✅ e2e-local-prod-nest-stable	41	4

📋 View full workflow run

vercel · 2026-01-26T22:21:09Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
example-nextjs-workflow-turbopack	Ready	Preview, Comment, Open in v0	Jan 30, 2026 8:36pm
example-nextjs-workflow-webpack	Ready	Preview, Comment, Open in v0	Jan 30, 2026 8:36pm
example-workflow	Ready	Preview, Comment, Open in v0	Jan 30, 2026 8:36pm
workbench-astro-workflow	Ready	Preview, Comment, Open in v0	Jan 30, 2026 8:36pm
workbench-express-workflow	Ready	Preview, Comment, Open in v0	Jan 30, 2026 8:36pm
workbench-fastify-workflow	Ready	Preview, Comment, Open in v0	Jan 30, 2026 8:36pm
workbench-hono-workflow	Ready	Preview, Comment, Open in v0	Jan 30, 2026 8:36pm
workbench-nitro-workflow	Ready	Preview, Comment, Open in v0	Jan 30, 2026 8:36pm
workbench-nuxt-workflow	Ready	Preview, Comment, Open in v0	Jan 30, 2026 8:36pm
workbench-sveltekit-workflow	Ready	Preview, Comment, Open in v0	Jan 30, 2026 8:36pm
workbench-vite-workflow	Ready	Preview, Comment, Open in v0	Jan 30, 2026 8:36pm
workflow-docs	Ready	Preview, Comment, Open in v0	Jan 30, 2026 8:36pm
workflow-nest	Ready	Preview, Comment, Open in v0	Jan 30, 2026 8:36pm

TooTallNate · 2026-01-26T22:21:19Z

Add support for "use step" functions in class instance methods #777 : 2 dependent PRs (#876 , #899 )
Add discovered serializable classes in all context modes #874
Ensure class serialization / deserialization only happens in the proper global context #873
Fix class ID generation when class is bound to a variable #872
Add discovery for custom classes with workflow serialization #859 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This pull request adds automatic discovery of files containing custom serialization classes for the workflow system, eliminating the need for explicit "use workflow" or "use step" directives in files that only define serialization classes.

Changes:

Added pattern detection for files importing from @workflow/serde or using Symbol.for('workflow-serialize'/'workflow-deserialize')
Updated discovery and transformation logic in builders, Rollup plugin, Next.js loader, and Vite hot-update plugin
Added comprehensive test coverage for the new pattern detection
Updated documentation explaining the automatic discovery mechanism

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
packages/vite/src/hot-update.ts	Added serde pattern detection to trigger hot reloads when custom serialization files change
packages/swc-plugin-workflow/spec.md	Documented the new automatic file discovery mechanism for custom serialization
packages/rollup/src/index.ts	Added serde pattern detection and exclusion patterns for generated files and SDK packages
packages/next/src/loader.ts	Added serde pattern detection and exclusion patterns for the Next.js webpack loader
packages/next/src/index.ts	Updated Turbopack conditions to detect serde patterns and exclude generated files
packages/builders/src/discover-entries-esbuild-plugin.ts	Added serde pattern detection to treat files with custom serialization like step files
packages/builders/src/discover-entries-esbuild-plugin.test.ts	Added comprehensive tests for all pattern detection regex patterns
.changeset/stale-eagles-pay.md	Added changeset documenting the feature addition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-27T00:06:28Z

packages/next/src/index.ts

                  {
-                    content: /(use workflow|use step)/,
+                    content:
+                      /(use workflow|use step|from\s+['"]@workflow\/serde['"]|Symbol\.for\s*\(\s*['"]workflow-(?:serialize|deserialize)['"]\s*\))/,


The regex pattern for detecting @workflow/serde imports doesn't use backreferences to ensure matching quote types. The pattern from\s+['"]@workflow\/serde['"] would incorrectly match malformed imports like from '@workflow/serde" (mixed quotes).

For consistency with the patterns used in other files (rollup, loader, vite, builders), consider using a backreference pattern like from\s+(['"])@workflow\/serde\1 to ensure the opening and closing quotes match. The same issue applies to the Symbol.for pattern which should use Symbol\.for\s*\(\s*(['"])workflow-(?:serialize|deserialize)\1\s*\) to ensure matching quotes around the symbol name.

Suggested change

/(use workflow|use step|from\s+['"]@workflow\/serde['"]|Symbol\.for\s*\(\s*['"]workflow-(?:serialize|deserialize)['"]\s*\))/,

/(use workflow|use step|from\s+(['"])@workflow\/serde\2|Symbol\.for\s*\(\s*(['"])workflow-(?:serialize|deserialize)\3\s*\))/,

Copilot · 2026-01-27T00:06:29Z

packages/rollup/src/index.ts

+// These packages are already built and don't need client-side transformation
+// Matches both: node_modules/@workflow/* and monorepo packages/*/dist paths
+const workflowSdkPathPattern =
+  /[/\\](?:@workflow[/\\]|packages[/\\](?:builders|core|rollup|vite|next|nitro|serde|workflow|swc-plugin-workflow)[/\\])/;


The workflowSdkPathPattern regex /[/\\](?:@workflow[/\\]|packages[/\\]...) doesn't match its comment which states it "Matches both: node_modules/@workflow/* and monorepo packages/*/dist paths". The regex will match any path containing @workflow[/\\], not just those under node_modules/.

This could incorrectly exclude user files from transformation if they have a directory named @workflow outside of node_modules. For consistency with the builders plugin (line 31-32 in packages/builders/src/discover-entries-esbuild-plugin.ts), consider either:

Updating the regex to include node_modules prefix: /[/\\](?:node_modules[/\\]@workflow[/\\]|packages[/\\]...)/

Or updating the comment to accurately reflect what the regex matches

Suggested change

/[/\\](?:@workflow[/\\]|packages[/\\](?:builders|core|rollup|vite|next|nitro|serde|workflow|swc-plugin-workflow)[/\\])/;

/[/\\](?:node_modules[/\\]@workflow[/\\]|packages[/\\](?:builders|core|rollup|vite|next|nitro|serde|workflow|swc-plugin-workflow)[/\\])/;

Copilot · 2026-01-27T00:06:29Z

packages/next/src/loader.ts

+// These packages are already built and don't need client-side transformation
+// Matches both: node_modules/@workflow/* and monorepo packages/*/dist paths
+const workflowSdkPathPattern =
+  /[/\\](?:@workflow[/\\]|packages[/\\](?:builders|core|rollup|vite|next|nitro|serde|workflow|swc-plugin-workflow)[/\\])/;


The workflowSdkPathPattern regex /[/\\](?:@workflow[/\\]|packages[/\\]...) doesn't match its comment which states it "Matches both: node_modules/@workflow/* and monorepo packages/*/dist paths". The regex will match any path containing @workflow[/\\], not just those under node_modules/.

This could incorrectly exclude user files from transformation if they have a directory named @workflow outside of node_modules. For consistency with the builders plugin (line 31-32 in packages/builders/src/discover-entries-esbuild-plugin.ts), consider either:

Updating the regex to include node_modules prefix: /[/\\](?:node_modules[/\\]@workflow[/\\]|packages[/\\]...)/

Or updating the comment to accurately reflect what the regex matches

Suggested change

/[/\\](?:@workflow[/\\]|packages[/\\](?:builders|core|rollup|vite|next|nitro|serde|workflow|swc-plugin-workflow)[/\\])/;

/[/\\](?:node_modules[/\\]@workflow[/\\]|packages[/\\](?:builders|core|rollup|vite|next|nitro|serde|workflow|swc-plugin-workflow)[/\\])/;

Copilot · 2026-01-27T00:06:29Z

packages/next/src/index.ts

+                // Use 'all' to combine: must match content AND must NOT be in generated path
+                all: [
+                  // Exclude generated workflow route files from transformation
+                  { not: { path: /[/\\]\.well-known[/\\]workflow[/\\]/ } },
+                  // Match files with workflow directives or custom serialization patterns
                  {
-                    content: /(use workflow|use step)/,
+                    content:
+                      /(use workflow|use step|from\s+['"]@workflow\/serde['"]|Symbol\.for\s*\(\s*['"]workflow-(?:serialize|deserialize)['"]\s*\))/,
                  },
                ],


The change from using any to all may not properly merge with existing conditions from existingRules[key]?.condition. The previous code (visible in the diff's removed lines) attempted to preserve existing conditions with ...existingRules[key]?.condition and merge with existingRules[key]?.condition.any || [].

The new implementation using all doesn't include any merge logic for pre-existing conditions. If there are existing conditions in existingRules[key], they will be completely overwritten rather than merged. This could break user configurations that already define custom turbopack rules for these file extensions.

Consider preserving existing conditions by merging them appropriately, for example:

If existing conditions use all, merge the new conditions into the existing all array

If existing conditions use any or other structures, wrap both old and new conditions appropriately

This comment is kind of valid but before we most likely still weren't going to match the same conditions if a user configured a loader with same regex so not new and a different regex could be used to avoid conflict by the user.

vercel

🔧 Build Fix:

The code is trying to instantiate OpenAI as a constructor, but the OpenAI type from the imported module has no construct signatures. This is a TypeScript type error where the OpenAI class is not being instantiated correctly.

Create shared transform-utils.ts in @workflow/builders with: - Pattern detection (directives, serde imports, Symbol.for) - Path exclusion checks (generated files, SDK files) - Combined shouldTransformFile logic Update rollup, next, and vite packages to use shared utilities instead of duplicated regex patterns.

VaguelySerious

LGTM but would love @ijjk 's input

TooTallNate · 2026-02-03T07:18:46Z

Merge activity

Feb 3, 7:18 AM UTC: A user started a stack merge that includes this pull request via Graphite.
Feb 3, 7:19 AM UTC: @TooTallNate merged this pull request with Graphite.

vercel bot had a problem deploying to Preview – workbench-vite-workflow January 26, 2026 22:23 Failure

vercel bot deployed to Preview – workbench-express-workflow January 26, 2026 22:23 View deployment

vercel bot deployed to Preview – workflow-docs January 26, 2026 22:23 View deployment

vercel bot deployed to Preview – workbench-nitro-workflow January 26, 2026 22:23 View deployment

vercel bot deployed to Preview – workbench-sveltekit-workflow January 26, 2026 22:23 View deployment

vercel bot deployed to Preview – workbench-astro-workflow January 26, 2026 22:23 View deployment

vercel bot deployed to Preview – workbench-hono-workflow January 26, 2026 22:23 View deployment

vercel bot deployed to Preview – workbench-fastify-workflow January 26, 2026 22:23 View deployment

vercel bot deployed to Preview – example-workflow January 26, 2026 22:23 View deployment

vercel bot deployed to Preview – example-nextjs-workflow-turbopack January 26, 2026 22:23 View deployment

vercel bot deployed to Preview – workbench-nuxt-workflow January 26, 2026 22:23 View deployment

vercel bot had a problem deploying to Preview – workflow-nest January 26, 2026 22:24 Failure

vercel bot deployed to Preview – example-nextjs-workflow-webpack January 26, 2026 22:24 View deployment

TooTallNate mentioned this pull request Jan 26, 2026

Enable custom class serialization transformations for "client" mode #860

Merged

vercel bot had a problem deploying to Preview – workbench-vite-workflow January 26, 2026 22:47 Failure

vercel bot deployed to Preview – workbench-hono-workflow January 26, 2026 22:47 View deployment

vercel bot had a problem deploying to Preview – example-nextjs-workflow-turbopack January 26, 2026 22:47 Failure

vercel bot deployed to Preview – workbench-astro-workflow January 26, 2026 22:47 View deployment

vercel bot deployed to Preview – workbench-sveltekit-workflow January 26, 2026 22:47 View deployment

vercel bot deployed to Preview – workflow-docs January 26, 2026 22:48 View deployment

vercel bot deployed to Preview – workbench-nuxt-workflow January 26, 2026 22:48 View deployment

vercel bot deployed to Preview – example-workflow January 26, 2026 22:48 View deployment

vercel bot deployed to Preview – workbench-nitro-workflow January 26, 2026 22:48 View deployment

vercel bot deployed to Preview – workbench-express-workflow January 26, 2026 22:48 View deployment

vercel bot deployed to Preview – example-nextjs-workflow-webpack January 26, 2026 22:48 View deployment

TooTallNate marked this pull request as ready for review January 27, 2026 00:01

Copilot AI review requested due to automatic review settings January 27, 2026 00:01

Copilot started reviewing on behalf of TooTallNate January 27, 2026 00:02 View session

TooTallNate requested review from ijjk and pranaygp January 27, 2026 00:03

Copilot AI reviewed Jan 27, 2026

View reviewed changes

vercel bot reviewed Jan 27, 2026

View reviewed changes

TooTallNate added 10 commits January 30, 2026 12:30

Add discovery for custom classes with workflow serialization

c066757

Fix Next turbopack case and vite

640f3c8

.

55d6ff9

.

35bd8a6

.

c4aaef4

Fix fetchWorkflow test case

b0fe05e

Rename test file to match module name

2107535

.

2f6dba2

.

14a46e1

TooTallNate mentioned this pull request Jan 30, 2026

Fix discovery of serde classes to detect [WORKFLOW_SERIALIZE] and [WORKFLOW_DESERIALIZE] computed property usage in bundled code #908

Merged

VaguelySerious approved these changes Feb 2, 2026

View reviewed changes

ijjk approved these changes Feb 3, 2026

View reviewed changes

vercel-release-bot mentioned this pull request Feb 3, 2026

Version Packages (beta) #921

Merged

	/(use workflow\|use step\|from\s+['"]@workflow\/serde['"]\|Symbol\.for\s\(\s['"]workflow-(?:serialize\|deserialize)['"]\s*\))/,
	/(use workflow\|use step\|from\s+(['"])@workflow\/serde\2\|Symbol\.for\s\(\s(['"])workflow-(?:serialize\|deserialize)\3\s*\))/,

	/[/\\](?:@workflow[/\\]\|packages[/\\](?:builders\|core\|rollup\|vite\|next\|nitro\|serde\|workflow\|swc-plugin-workflow)[/\\])/;
	/[/\\](?:node_modules[/\\]@workflow[/\\]\|packages[/\\](?:builders\|core\|rollup\|vite\|next\|nitro\|serde\|workflow\|swc-plugin-workflow)[/\\])/;

Conversation

TooTallNate commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed?

How to test?

Why make this change?

Uh oh!

changeset-bot bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Benchmark Results

💻 Local Development

▲ Production (Vercel)

💻 Local Development

▲ Production (Vercel)

💻 Local Development

▲ Production (Vercel)

💻 Local Development

▲ Production (Vercel)

💻 Local Development

▲ Production (Vercel)

💻 Local Development

▲ Production (Vercel)

💻 Local Development

▲ Production (Vercel)

💻 Local Development

▲ Production (Vercel)

Summary

Uh oh!

github-actions bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 E2E Test Results

Summary

❌ Failed Tests

Details by Category

Uh oh!

vercel bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TooTallNate commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

ijjk Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

vercel bot left a comment

Choose a reason for hiding this comment

Uh oh!

VaguelySerious left a comment

Choose a reason for hiding this comment

Uh oh!

TooTallNate commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

TooTallNate commented Jan 26, 2026 •

edited

Loading

changeset-bot bot commented Jan 26, 2026 •

edited

Loading

github-actions bot commented Jan 26, 2026 •

edited

Loading

github-actions bot commented Jan 26, 2026 •

edited

Loading

vercel bot commented Jan 26, 2026 •

edited

Loading

TooTallNate commented Jan 26, 2026 •

edited

Loading

TooTallNate commented Feb 3, 2026 •

edited

Loading