Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactor web-shared to separate UI components from server concerns#927

Merged
karthikscale3 merged 18 commits intomainfrom
karthik/expose-props-traceviewer
Feb 6, 2026
Merged

Refactor web-shared to separate UI components from server concerns#927
karthikscale3 merged 18 commits intomainfrom
karthik/expose-props-traceviewer

Conversation

@karthikscale3
Copy link
Collaborator

@karthikscale3 karthikscale3 commented Feb 4, 2026

Summary

  • Restructure @workflow/web-shared to be a pure UI component library by moving server-side code to @workflow/web
  • Add world-actions/ module with shared world operation helpers that don't depend on Next.js server actions
  • Add runtime subpath exports to @workflow/core for direct module imports

Changes

@workflow/web-shared

  • Move all UI components into src/components/ subdirectory
  • Remove server actions and API client (moved to @workflow/web)
  • Remove server subpackage
  • Breaking: Components now accept callbacks as props (e.g., onSpanSelect, onWakeUpSleep, onResolveHook) instead of directly calling server actions

@workflow/web

  • Add src/server/workflow-server-actions.ts with all server actions
  • Add src/lib/workflow-api-client.ts for client-side API wrapper
  • Add src/lib/hooks/use-stream-reader.ts hook
  • Update components to use prop-based callbacks

@workflow/core

  • Add subpath exports: ./runtime/start, ./runtime/helpers, ./runtime/resume-hook
  • Add runs.ts module with shared helpers (recreateRunFromExisting, cancelRun, reenqueueRun, wakeUpRun)

Test plan

Local o11y

  • Verify trace viewer renders correctly
  • Test replay run functionality from web dashboard
  • Test cancel run functionality
  • Test wake up sleep functionality
  • Verify streams display correctly

Vercel o11y

  • Verify trace viewer renders correctly
  • Test replay run functionality from web dashboard
  • Test cancel run functionality
  • Test wake up sleep functionality
  • Verify streams display correctly

- Move UI components into src/components/ subdirectory
- Move server actions and API client to @workflow/web
- Add world-actions/ module with shared helpers (recreateRun, cancelRun, etc.)
- Add runtime subpath exports to @workflow/core
- Components now accept callbacks as props for data fetching
@vercel
Copy link
Contributor

vercel bot commented Feb 4, 2026

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2026

🦋 Changeset detected

Latest commit: 84e167e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@workflow/web-shared Patch
@workflow/core Patch
@workflow/web Patch
@workflow/builders Patch
@workflow/cli Patch
@workflow/docs-typecheck Patch
@workflow/next Patch
@workflow/nitro Patch
workflow Patch
@workflow/astro Patch
@workflow/nest Patch
@workflow/rollup Patch
@workflow/sveltekit Patch
@workflow/vite Patch
@workflow/world-testing Patch
@workflow/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 0.038s (~) 1.017s (~) 0.979s 10 1.00x
💻 Local Nitro 0.043s (-4.2%) 1.008s (~) 0.965s 10 1.13x
💻 Local Express 0.044s (+3.8%) 1.008s (~) 0.964s 10 1.15x
🐘 Postgres Nitro 0.201s (+22.8% 🔺) 1.014s (~) 0.813s 10 5.27x
🐘 Postgres Express 0.250s (+22.3% 🔺) 1.014s (~) 0.764s 10 6.57x
🐘 Postgres Next.js (Turbopack) 0.381s (+9.9% 🔺) 1.025s (~) 0.644s 10 10.01x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Nitro 0.621s (-4.4%) 1.740s (+10.9% 🔺) 1.119s 10 1.00x
▲ Vercel Express 0.633s (-7.8% 🟢) 1.550s (-2.6%) 0.917s 10 1.02x
▲ Vercel Next.js (Turbopack) 0.739s (+20.4% 🔺) 1.631s (+10.4% 🔺) 0.892s 10 1.19x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

workflow with 1 step

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 1.095s (-0.6%) 2.014s (~) 0.919s 10 1.00x
💻 Local Nitro 1.118s (~) 2.008s (~) 0.890s 10 1.02x
💻 Local Express 1.119s (~) 2.008s (~) 0.889s 10 1.02x
🐘 Postgres Next.js (Turbopack) 2.040s (-1.2%) 2.719s (-6.8% 🟢) 0.679s 10 1.86x
🐘 Postgres Express 2.143s (-6.6% 🟢) 3.016s (~) 0.873s 10 1.96x
🐘 Postgres Nitro 2.340s (-1.1%) 3.016s (~) 0.676s 10 2.14x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Nitro 2.519s (+2.1%) 3.443s (-8.3% 🟢) 0.924s 10 1.00x
▲ Vercel Express 2.549s (~) 3.600s (~) 1.051s 10 1.01x
▲ Vercel Next.js (Turbopack) 2.679s (+7.2% 🔺) 3.702s (+4.2%) 1.023s 10 1.06x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

workflow with 10 sequential steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 10.706s (~) 11.024s (~) 0.318s 3 1.00x
💻 Local Nitro 10.831s (~) 11.017s (~) 0.186s 3 1.01x
💻 Local Express 10.851s (~) 11.014s (~) 0.163s 3 1.01x
🐘 Postgres Next.js (Turbopack) 15.553s (~) 16.048s (~) 0.496s 2 1.45x
🐘 Postgres Nitro 20.430s (~) 21.033s (~) 0.603s 2 1.91x
🐘 Postgres Express 20.476s (~) 21.028s (~) 0.553s 2 1.91x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Next.js (Turbopack) 19.655s (-2.3%) 20.298s (-3.0%) 0.643s 2 1.00x
▲ Vercel Express 19.881s (-3.0%) 21.025s (-1.8%) 1.145s 2 1.01x
▲ Vercel Nitro 19.931s (~) 21.028s (+1.9%) 1.096s 2 1.01x

🔍 Observability: Next.js (Turbopack) | Express | Nitro

workflow with 25 sequential steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 27.188s (~) 28.043s (~) 0.855s 3 1.00x
💻 Local Nitro 27.493s (~) 28.035s (~) 0.542s 3 1.01x
💻 Local Express 27.507s (~) 28.027s (~) 0.520s 3 1.01x
🐘 Postgres Express 37.851s (-24.8% 🟢) 38.064s (-25.5% 🟢) 0.213s 2 1.39x
🐘 Postgres Next.js (Turbopack) 46.941s (+24.1% 🔺) 47.575s (+25.0% 🔺) 0.635s 2 1.73x
🐘 Postgres Nitro 50.296s (~) 51.075s (~) 0.779s 2 1.85x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Nitro 49.105s (+1.0%) 50.410s (+1.6%) 1.305s 2 1.00x
▲ Vercel Express 49.636s (+1.0%) 50.766s (+2.0%) 1.130s 2 1.01x
▲ Vercel Next.js (Turbopack) 49.706s (-2.1%) 50.228s (-2.2%) 0.521s 2 1.01x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

workflow with 50 sequential steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 56.602s (~) 57.066s (~) 0.464s 2 1.00x
💻 Local Nitro 57.183s (~) 58.043s (~) 0.860s 2 1.01x
💻 Local Express 57.334s (~) 58.051s (~) 0.717s 2 1.01x
🐘 Postgres Express 74.657s (-20.7% 🟢) 75.611s (-19.7% 🟢) 0.953s 2 1.32x
🐘 Postgres Next.js (Turbopack) 75.542s (+3.0%) 76.136s (+3.4%) 0.594s 2 1.33x
🐘 Postgres Nitro 100.578s (~) 101.100s (~) 0.522s 1 1.78x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Nitro 102.837s (-3.0%) 103.669s (-3.1%) 0.832s 1 1.00x
▲ Vercel Express 104.254s (-1.1%) 105.281s (~) 1.027s 1 1.01x
▲ Vercel Next.js (Turbopack) 104.909s (-2.0%) 105.322s (-2.0%) 0.413s 1 1.02x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Promise.all with 10 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 1.386s (-2.3%) 2.011s (~) 0.625s 15 1.00x
💻 Local Express 1.416s (+0.8%) 2.008s (~) 0.592s 15 1.02x
💻 Local Nitro 1.427s (~) 2.006s (~) 0.579s 15 1.03x
🐘 Postgres Express 1.972s (-11.2% 🟢) 2.319s (-23.0% 🟢) 0.347s 13 1.42x
🐘 Postgres Nitro 2.327s (-3.6%) 3.012s (~) 0.686s 10 1.68x
🐘 Postgres Next.js (Turbopack) 2.429s (+27.9% 🔺) 3.014s (+19.8% 🔺) 0.585s 10 1.75x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Nitro 2.725s (-4.3%) 3.752s (-1.1%) 1.027s 9 1.00x
▲ Vercel Express 2.764s (-1.8%) 3.867s (+1.5%) 1.103s 8 1.01x
▲ Vercel Next.js (Turbopack) 2.970s (-9.1% 🟢) 4.097s (-6.4% 🟢) 1.127s 8 1.09x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Promise.all with 25 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 2.506s (~) 3.043s (~) 0.537s 10 1.00x
💻 Local Nitro 2.572s (-2.0%) 3.016s (~) 0.444s 10 1.03x
💻 Local Express 2.643s (+3.7%) 3.012s (~) 0.369s 10 1.05x
🐘 Postgres Nitro 9.452s (+24.2% 🔺) 10.074s (+21.9% 🔺) 0.622s 3 3.77x
🐘 Postgres Express 9.796s (+17.2% 🔺) 10.364s (+14.5% 🔺) 0.568s 3 3.91x
🐘 Postgres Next.js (Turbopack) 10.526s (-15.4% 🟢) 11.024s (-15.7% 🟢) 0.498s 3 4.20x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 3.113s (~) 4.159s (+2.7%) 1.046s 8 1.00x
▲ Vercel Next.js (Turbopack) 3.455s (+15.4% 🔺) 4.107s (+9.3% 🔺) 0.652s 8 1.11x
▲ Vercel Nitro 3.837s (+22.7% 🔺) 4.849s (+21.0% 🔺) 1.013s 7 1.23x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.all with 50 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 7.147s (+4.1%) 8.279s (+1.5%) 1.132s 4 1.00x
💻 Local Nitro 7.287s (-1.7%) 8.295s (-1.0%) 1.008s 4 1.02x
💻 Local Express 7.733s (+6.1% 🔺) 8.673s (+4.6%) 0.940s 4 1.08x
🐘 Postgres Nitro 44.164s (-10.5% 🟢) 44.258s (-12.0% 🟢) 0.094s 1 6.18x
🐘 Postgres Express 50.535s (+2.9%) 51.162s (+3.6%) 0.627s 1 7.07x
🐘 Postgres Next.js (Turbopack) 52.723s (-4.4%) 53.145s (-3.7%) 0.422s 1 7.38x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 5.751s (+79.5% 🔺) 6.615s (+65.3% 🔺) 0.864s 5 1.00x
▲ Vercel Nitro 7.043s (+22.6% 🔺) 7.939s (+24.8% 🔺) 0.895s 4 1.22x
▲ Vercel Next.js (Turbopack) 8.330s (+109.0% 🔺) 9.380s (+80.9% 🔺) 1.050s 4 1.45x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

Promise.race with 10 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 1.402s (-2.8%) 2.009s (~) 0.608s 15 1.00x
💻 Local Nitro 1.428s (-2.0%) 2.006s (~) 0.578s 15 1.02x
💻 Local Express 1.462s (+2.8%) 2.009s (~) 0.547s 15 1.04x
🐘 Postgres Express 1.735s (-23.3% 🟢) 2.011s (-22.7% 🟢) 0.276s 15 1.24x
🐘 Postgres Next.js (Turbopack) 2.038s (-18.3% 🟢) 2.525s (-11.0% 🟢) 0.487s 12 1.45x
🐘 Postgres Nitro 2.116s (-4.1%) 2.613s (-7.9% 🟢) 0.497s 12 1.51x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Nitro 2.583s (~) 3.598s (-3.2%) 1.015s 9 1.00x
▲ Vercel Next.js (Turbopack) 2.613s (+1.6%) 3.495s (-3.0%) 0.883s 9 1.01x
▲ Vercel Express 2.776s (+9.7% 🔺) 3.843s (+7.1% 🔺) 1.068s 8 1.07x

🔍 Observability: Nitro | Next.js (Turbopack) | Express

Promise.race with 25 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Nitro 2.688s (-0.8%) 3.013s (~) 0.325s 10 1.00x
💻 Local Next.js (Turbopack) 2.691s (+0.7%) 3.135s (+3.3%) 0.444s 10 1.00x
💻 Local Express 2.810s (+4.9%) 3.033s (+0.7%) 0.223s 10 1.05x
🐘 Postgres Nitro 11.557s (-0.6%) 11.688s (-5.4% 🟢) 0.131s 3 4.30x
🐘 Postgres Express 11.741s (~) 12.040s (~) 0.299s 3 4.37x
🐘 Postgres Next.js (Turbopack) 13.253s (-7.4% 🟢) 13.721s (-6.7% 🟢) 0.468s 3 4.93x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Nitro 2.778s (~) 3.998s (+10.2% 🔺) 1.220s 8 1.00x
▲ Vercel Express 2.822s (-1.8%) 3.768s (+1.6%) 0.946s 8 1.02x
▲ Vercel Next.js (Turbopack) 3.061s (+6.0% 🔺) 4.123s (+13.2% 🔺) 1.062s 8 1.10x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Promise.race with 50 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 7.739s (+6.6% 🔺) 8.630s (+2.0%) 0.891s 4 1.00x
💻 Local Nitro 7.757s (+0.9%) 8.710s (~) 0.953s 4 1.00x
💻 Local Express 8.613s (+12.8% 🔺) 9.617s (+11.3% 🔺) 1.005s 4 1.11x
🐘 Postgres Nitro 50.401s (-1.8%) 51.095s (-2.1%) 0.694s 1 6.51x
🐘 Postgres Express 53.446s (+3.2%) 54.221s (+3.9%) 0.775s 1 6.91x
🐘 Postgres Next.js (Turbopack) 54.858s (-5.5% 🟢) 55.204s (-5.0% 🟢) 0.346s 1 7.09x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 3.248s (-27.0% 🟢) 3.854s (-25.9% 🟢) 0.606s 8 1.00x
▲ Vercel Next.js (Turbopack) 3.428s (-16.6% 🟢) 3.999s (-17.9% 🟢) 0.571s 8 1.06x
▲ Vercel Nitro 3.543s (-24.4% 🟢) 4.353s (-25.5% 🟢) 0.810s 7 1.09x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Stream Benchmarks (includes TTFB metrics)
workflow with stream

💻 Local Development

World Framework Workflow Time TTFB Slurp Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 0.153s (+6.2% 🔺) 1.003s (~) 0.015s (+5.5% 🔺) 1.025s (~) 0.873s 10 1.00x
💻 Local Nitro 0.182s (~) 0.993s (~) 0.014s (-0.7%) 1.021s (~) 0.839s 10 1.19x
💻 Local Express 0.188s (+3.8%) 0.991s (~) 0.015s (+5.7% 🔺) 1.023s (~) 0.835s 10 1.23x
🐘 Postgres Nitro 1.341s (-45.5% 🟢) 1.700s (-34.1% 🟢) 0.000s (-100.0% 🟢) 2.014s (-33.2% 🟢) 0.673s 10 8.79x
🐘 Postgres Express 1.343s (-42.0% 🟢) 1.691s (-38.0% 🟢) 0.000s (NaN%) 2.013s (-33.2% 🟢) 0.670s 10 8.80x
🐘 Postgres Next.js (Turbopack) 1.373s (+48.4% 🔺) 1.667s (+55.8% 🔺) 0.000s (NaN%) 2.017s (+53.2% 🔺) 0.643s 10 9.00x

▲ Production (Vercel)

World Framework Workflow Time TTFB Slurp Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 2.350s (-8.2% 🟢) 2.761s (-8.6% 🟢) 0.213s (+11.7% 🔺) 3.452s (-7.4% 🟢) 1.102s 10 1.00x
▲ Vercel Nitro 2.408s (+1.3%) 2.804s (+8.1% 🔺) 0.272s (+6.8% 🔺) 3.606s (+9.0% 🔺) 1.198s 10 1.02x
▲ Vercel Next.js (Turbopack) 2.571s (+8.5% 🔺) 2.991s (+20.9% 🔺) 0.127s (-18.9% 🟢) 3.657s (+15.7% 🔺) 1.086s 10 1.09x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World 🥇 Fastest Framework Wins
💻 Local Next.js (Turbopack) 11/12
🐘 Postgres Nitro 6/12
▲ Vercel Nitro 7/12
Fastest World by Framework

Winner determined by most benchmark wins

Framework 🥇 Fastest World Wins
Express 💻 Local 10/12
Next.js (Turbopack) 💻 Local 11/12
Nitro 💻 Local 10/12
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Starter: Community world (local development)
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

🧪 E2E Test Results

Some tests failed

Summary

Passed Failed Skipped Total
✅ ▲ Vercel Production 479 0 38 517
✅ 💻 Local Development 438 0 32 470
✅ 📦 Local Production 438 0 32 470
✅ 🐘 Local Postgres 438 0 32 470
✅ 🪟 Windows 47 0 0 47
❌ 🌍 Community Worlds 31 169 0 200
✅ 📋 Other 129 0 12 141
Total 2000 169 146 2315

❌ Failed Tests

🌍 Community Worlds (169 failed)

mongodb (42 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • readableStreamWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • outputStreamWorkflow
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

redis (42 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • readableStreamWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • outputStreamWorkflow
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

starter (43 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • readableStreamWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • outputStreamWorkflow
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

turso (42 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • readableStreamWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • outputStreamWorkflow
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

Details by Category

✅ ▲ Vercel Production
App Passed Failed Skipped
✅ astro 43 0 4
✅ example 43 0 4
✅ express 43 0 4
✅ fastify 43 0 4
✅ hono 43 0 4
✅ nextjs-turbopack 46 0 1
✅ nextjs-webpack 46 0 1
✅ nitro 43 0 4
✅ nuxt 43 0 4
✅ sveltekit 43 0 4
✅ vite 43 0 4
✅ 💻 Local Development
App Passed Failed Skipped
✅ astro-stable 43 0 4
✅ express-stable 43 0 4
✅ fastify-stable 43 0 4
✅ hono-stable 43 0 4
✅ nextjs-turbopack-stable 47 0 0
✅ nextjs-webpack-stable 47 0 0
✅ nitro-stable 43 0 4
✅ nuxt-stable 43 0 4
✅ sveltekit-stable 43 0 4
✅ vite-stable 43 0 4
✅ 📦 Local Production
App Passed Failed Skipped
✅ astro-stable 43 0 4
✅ express-stable 43 0 4
✅ fastify-stable 43 0 4
✅ hono-stable 43 0 4
✅ nextjs-turbopack-stable 47 0 0
✅ nextjs-webpack-stable 47 0 0
✅ nitro-stable 43 0 4
✅ nuxt-stable 43 0 4
✅ sveltekit-stable 43 0 4
✅ vite-stable 43 0 4
✅ 🐘 Local Postgres
App Passed Failed Skipped
✅ astro-stable 43 0 4
✅ express-stable 43 0 4
✅ fastify-stable 43 0 4
✅ hono-stable 43 0 4
✅ nextjs-turbopack-stable 47 0 0
✅ nextjs-webpack-stable 47 0 0
✅ nitro-stable 43 0 4
✅ nuxt-stable 43 0 4
✅ sveltekit-stable 43 0 4
✅ vite-stable 43 0 4
✅ 🪟 Windows
App Passed Failed Skipped
✅ nextjs-turbopack 47 0 0
❌ 🌍 Community Worlds
App Passed Failed Skipped
✅ mongodb-dev 3 0 0
❌ mongodb 5 42 0
✅ redis-dev 3 0 0
❌ redis 5 42 0
✅ starter-dev 3 0 0
❌ starter 4 43 0
✅ turso-dev 3 0 0
❌ turso 5 42 0
✅ 📋 Other
App Passed Failed Skipped
✅ e2e-local-dev-nest-stable 43 0 4
✅ e2e-local-postgres-nest-stable 43 0 4
✅ e2e-local-prod-nest-stable 43 0 4

📋 View full workflow run

@socket-security
Copy link

socket-security bot commented Feb 4, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​workflow/​errors@​4.1.0-beta.141001006998100
Addednpm/​@​workflow/​world-vercel@​4.1.0-beta.299910073100100

View full report

@karthikscale3 karthikscale3 requested review from TooTallNate, VaguelySerious and pranaygp and removed request for TooTallNate February 4, 2026 05:44
Copy link
Member

@VaguelySerious VaguelySerious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I think this should instead be:

<WorkflowTraceViewer worldApi={worldApi} />

and similar for streamers, etc.

@pranaygp
Copy link
Collaborator

pranaygp commented Feb 6, 2026

@claude can you review this and leave inline review comments please

@claude
Copy link

claude bot commented Feb 6, 2026

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors @workflow/web-shared to separate UI components from server-side code, creating a cleaner architecture where:

  • @workflow/web-shared becomes a pure UI component library with prop-based callbacks
  • @workflow/web contains all server actions and API client code
  • @workflow/core adds runtime subpath exports for direct module imports

Changes:

  • Moved server actions from web-shared to web
  • Converted components to accept callbacks as props instead of environment variables
  • Added world operation helpers to @workflow/core/runtime
  • Removed server subpackage from web-shared

Reviewed changes

Copilot reviewed 38 out of 71 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
pnpm-lock.yaml Updated dependencies, switched workspace packages to specific versions
packages/web/src/server/workflow-server-actions.ts Consolidated server actions, uses runtime helpers from core
packages/web/src/lib/workflow-api-client.ts Enhanced with hook fetching and conditional data loading
packages/web/src/components/*.tsx Updated to use local server actions and pass callbacks to UI components
packages/web-shared/src/components/*.tsx Refactored to pure UI components accepting data and callbacks
packages/core/src/runtime/runs.ts New shared helper functions for world operations
packages/core/package.json Added runtime subpath exports
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (3)

packages/web/src/lib/workflow-api-client.ts:1040

  • The enabled option defaults to true but the loading state is initialized with this value directly. This means that when enabled is false, the component still briefly shows a loading state. Consider initializing loading state with false when enabled is false from the start.
    packages/web-shared/src/components/sidebar/events-list.tsx:5
  • The import path includes .js extension in '../trace-viewer/types.js' while other imports don't use extensions. This inconsistency could cause issues with some TypeScript/bundler configurations. Consider removing the .js extension for consistency with other imports in the file.
    packages/web/src/server/workflow-server-actions.ts:52
  • The function createVercelWorld is being redefined locally when @workflow/world-vercel already exports this function. This creates code duplication and maintenance burden. Consider importing and using the existing function from the package instead of reimplementing it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@karthikscale3
Copy link
Collaborator Author

  • Tests / E2E Local Dev Tests (astro - stable) (pull_request)

Aligned that this will be iterated in the next phase.

* Ensures the workflow name only contains safe characters before
* interpolating it into the queue name string.
*/
export function getWorkflowQueueName(workflowName: string): ValidQueueName {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants