Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

CPWstatic
Copy link
Contributor

No description provided.

@CPWstatic CPWstatic added the ready-for-testing PR: ready for the CI test label Mar 29, 2020
@codecov-io
Copy link

codecov-io commented Mar 29, 2020

Codecov Report

Merging #2013 into master will decrease coverage by 0.16%.
The diff coverage is 93.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2013      +/-   ##
==========================================
- Coverage   86.90%   86.73%   -0.17%     
==========================================
  Files         636      641       +5     
  Lines       59819    61117    +1298     
==========================================
+ Hits        51984    53010    +1026     
- Misses       7835     8107     +272     
Impacted Files Coverage Δ
src/common/base/Configuration.h 100.00% <ø> (ø)
src/common/utils/NebulaKeyUtils.cpp 100.00% <ø> (ø)
src/common/utils/NebulaKeyUtils.h 90.41% <ø> (ø)
src/common/utils/test/NebulaKeyUtilsTest.cpp 97.10% <ø> (ø)
src/graph/DescribeSpaceExecutor.h 0.00% <ø> (ø)
src/graph/FetchEdgesExecutor.h 0.00% <ø> (ø)
src/graph/FetchExecutor.cpp 87.77% <ø> (-0.53%) ⬇️
src/graph/FetchVerticesExecutor.h 0.00% <ø> (ø)
src/graph/GoExecutor.h 56.25% <ø> (ø)
src/graph/GraphService.h 100.00% <ø> (ø)
... and 201 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fc4e7f...606c04c. Read the comment docs.

@jude-zhu
Copy link
Contributor

close #1982

@CPWstatic CPWstatic added in progress and removed ready-for-testing PR: ready for the CI test labels Apr 1, 2020
@CPWstatic CPWstatic added ready-for-testing PR: ready for the CI test and removed in progress labels Apr 1, 2020
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. LGTM

Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dutor dutor merged commit 8810ecc into vesoft-inc:master Apr 2, 2020
jude-zhu pushed a commit to jude-zhu/nebula that referenced this pull request Apr 2, 2020
* Sampling from all edges.

* Update test for sampling multi edges.

* Testing both inbound and outbound.

* Fix clang compiling problem.

* Update the sampling.

Co-authored-by: dutor <[email protected]>
(cherry picked from commit 8810ecc)
dutor pushed a commit that referenced this pull request Apr 2, 2020
* remove bigint because we dont support it (#2031)

Co-authored-by: dutor <[email protected]>
(cherry picked from commit 3423df1)

* fix crash (#2042)

Co-authored-by: dutor <[email protected]>
(cherry picked from commit eea7407)

* Sampling apply to all edges starting from a vertex. (#2013)

* Sampling from all edges.

* Update test for sampling multi edges.

* Testing both inbound and outbound.

* Fix clang compiling problem.

* Update the sampling.

Co-authored-by: dutor <[email protected]>
(cherry picked from commit 8810ecc)

* Fix the error when vertex/edge not exist if update. (#2025)

* Fix the error when vertex/edge not exist if update.

* Optimize the atomic error logical.

* Fix one alignment.

Co-authored-by: dutor <[email protected]>
(cherry picked from commit 9fc4e7f)

* Correct issue 2009 which the timestamp default value for edge not treat. (#2038)

* Correct issue 2009 which the timestamp default value for edge not treat.

* Add the cover cases.

* Fix one typo.

Co-authored-by: dutor <[email protected]>
(cherry picked from commit 4aa9217)

Co-authored-by: flyingcat <[email protected]>
Co-authored-by: laura-ding <[email protected]>
Co-authored-by: CPWstatic <[email protected]>
Co-authored-by: Shylock Hg <[email protected]>
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* Sampling from all edges.

* Update test for sampling multi edges.

* Testing both inbound and outbound.

* Fix clang compiling problem.

* Update the sampling.

Co-authored-by: dutor <[email protected]>
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
* update tck of kill-query

* format

* fix tck

* add some tck

* fix copyright

* copyright

Co-authored-by: Sophie <[email protected]>

Co-authored-by: canon <[email protected]>
Co-authored-by: Sophie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants