Late evaluation support for logging in the CEA-608 parser. #4939
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Reduce CPU time on low-powered devices where these logging calls were taking up a measurable amount of time in the overall profile.
~14.1% of time in a profile spanning multiple segment downloads was spent in
getDisplayedText
on a Samsung Tizen TV.Are there any points in the code the reviewer needs to double check?
Standard review.
I tried to limit the changes to the exact calls that would have the highest impact, so anything that required computation to calculate. I left ones that were just constructing new strings alone, because a deeper analysis on string heap collection versus dangling function references would need to be done to know which led to better performance, and ensure no leaks were introduced.
Checklist