Support playback for elementary audio stream encrypted using Sample-AES #7479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
requested changes
Aug 24, 2025
src/demux/audio/aacdemuxer.ts
Outdated
| @@ -91,6 +98,29 @@ class AACDemuxer extends BaseAudioDemuxer { | |||
| return frame; | |||
| } | |||
| } | |||
|
|
|||
| async demuxSampleAes( | |||
There was a problem hiding this comment.
Do not use the async keyword - Babel adds the regenerator lib to the ES5 output to support it, which increases the bundle size significantly.
There was a problem hiding this comment.
Opened #7480 so that this is caught by the linter:
There was a problem hiding this comment.
Thank you for the tips! I've removed it in 370b905
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Allow
hls.jsto decrypt Elementary Audio Stream of Sample-AES.Why is this Pull Request needed?
Aside of traditional MPEG-TS based container, Sample-AES allows carry raw encrypted audio data.
Reference:
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist