Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix encoding of E325 message #4685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
k-takata wants to merge 2 commits into from
Closed

Fix encoding of E325 message #4685

k-takata wants to merge 2 commits into from

Conversation

@k-takata
Copy link
Member

@k-takata k-takata commented Jul 16, 2019

Fixes #4681.

Also make the time format of the E325 message translatable.

@k-takata k-takata mentioned this pull request Jul 16, 2019
Closed
@codecov-io
Copy link

codecov-io commented Jul 16, 2019

Codecov Report

Merging #4685 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4685      +/-   ##
==========================================
+ Coverage   81.33%   81.36%   +0.02%     
==========================================
  Files         110      114       +4     
  Lines      144866   145131     +265     
==========================================
+ Hits       117832   118080     +248     
- Misses      27034    27051      +17
Impacted Files Coverage Δ
src/memline.c 78.1% <100%> (ø) ⬆️
src/gui_beval.c 62.5% <0%> (-0.87%) ⬇️
src/if_xcmdsrv.c 85.63% <0%> (-0.54%) ⬇️
src/ex_cmds.c 82.18% <0%> (-0.25%) ⬇️
src/os_unix.c 63.35% <0%> (-0.18%) ⬇️
src/gui_gtk_x11.c 57.86% <0%> (-0.1%) ⬇️
src/window.c 87.33% <0%> (-0.07%) ⬇️
src/json_test.c 100% <0%> (ø)
src/memfile_test.c 100% <0%> (ø)
src/kword_test.c 66.66% <0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 250e311...93537c4. Read the comment docs.

@brammool brammool closed this in 663bbc0 Jul 21, 2019
@k-takata k-takata deleted the fix-4681 branch July 21, 2019 13:29
manuelschiller pushed a commit to manuelschiller/vim that referenced this pull request Nov 10, 2019
@brammool @manuelschiller
patch 8.1.1725: MS-Windows: E325 message may use incorrect date format
a34072f 
Problem:    MS-Windows: E325 message may use incorrect date format.
Solution:   Convert strftime() result to 'encoding'.  Also make the message
            translatable. (Ken Takata, closes vim#4685, closes vim#4681)
janlazo added a commit to janlazo/neovim that referenced this pull request Aug 28, 2020
@janlazo
vim-patch:8.1.1725: MS-Windows: E325 message may use incorrect date f…
e8983c0 
…ormat

Problem:    MS-Windows: E325 message may use incorrect date format.
Solution:   Convert strftime() result to 'encoding'.  Also make the message
            translatable. (Ken Takata, closes vim/vim#4685, closes vim/vim#4681)
vim/vim@663bbc0
janlazo added a commit to janlazo/neovim that referenced this pull request Aug 31, 2020
@janlazo
vim-patch:8.1.1725: MS-Windows: E325 message may use incorrect date f…
269a271 
…ormat

Problem:    MS-Windows: E325 message may use incorrect date format.
Solution:   Convert strftime() result to 'encoding'.  Also make the message
            translatable. (Ken Takata, closes vim/vim#4685, closes vim/vim#4681)
vim/vim@663bbc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

E325 message incorrectly displays day of week/month under Windows if "encoding" is set to "utf-8"

2 participants

@k-takata @codecov-io