Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix not evaluated dictionary access with scriptversion 2 is always error #4704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kuuote wants to merge 2 commits into from
Closed

Fix not evaluated dictionary access with scriptversion 2 is always error #4704

kuuote wants to merge 2 commits into from

Conversation

@kuuote
Copy link
Contributor

@kuuote kuuote commented Jul 20, 2019

Problem

An error occurs when run a script containing unevaluated dictionary access with scriptversion 2.

Reproduce step

sample.vim

scriptversion 2

let x = {'foo': 0}

if 0 && x.foo
  echo 'foo'
endif
$ vim -u NONE -i NONE -N -S sample.vim

Cause

Unevaluted dot operator is always treated as a string concat.

How to fix

Skip string concat checking when unevaluating.

@kuuote kuuote mentioned this pull request Jul 20, 2019
Closed
@codecov-io
Copy link

codecov-io commented Jul 20, 2019

Codecov Report

Merging #4704 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4704      +/-   ##
==========================================
+ Coverage   81.35%   81.36%   +0.01%     
==========================================
  Files         114      114              
  Lines      145212   145212              
==========================================
+ Hits       118143   118158      +15     
+ Misses      27069    27054      -15
Impacted Files Coverage Δ
src/eval.c 86.32% <100%> (ø) ⬆️
src/if_xcmdsrv.c 85.63% <0%> (-0.54%) ⬇️
src/window.c 87.39% <0%> (+0.09%) ⬆️
src/gui_gtk_x11.c 58.01% <0%> (+0.14%) ⬆️
src/os_unix.c 63.53% <0%> (+0.17%) ⬆️
src/ex_cmds.c 82.33% <0%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0a789...1418180. Read the comment docs.

@brammool brammool closed this in 61343f0 Jul 20, 2019
manuelschiller pushed a commit to manuelschiller/vim that referenced this pull request Nov 10, 2019
@brammool @manuelschiller
patch 8.1.1722: error when scriptversion is 2 a making a dictionary a…
cebc6b0 
…ccess

Problem:    Error when scriptversion is 2 a making a dictionary access.
Solution:   Parse the subscript even when not evaluating the sub-expression.
            (closes vim#4704)
seandewar added a commit to seandewar/neovim that referenced this pull request May 21, 2021
@seandewar
vim-patch:8.1.1722: error when scriptversion is 2 a making a dictiona…
e129442 
…ry access

Problem:    Error when scriptversion is 2 a making a dictionary access.
Solution:   Parse the subscript even when not evaluating the sub-expression.
            (closes vim/vim#4704)
vim/vim@61343f0
seandewar added a commit to seandewar/neovim that referenced this pull request May 21, 2021
@seandewar
vim-patch:8.1.1722: error when scriptversion is 2 a making a dictiona…
944c94d 
…ry access

Problem:    Error when scriptversion is 2 a making a dictionary access.
Solution:   Parse the subscript even when not evaluating the sub-expression.
            (closes vim/vim#4704)
vim/vim@61343f0
seandewar added a commit to seandewar/neovim that referenced this pull request May 21, 2021
@seandewar
vim-patch:8.1.1722: error when scriptversion is 2 a making a dictiona…
dbf6d6b 
…ry access

Problem:    Error when scriptversion is 2 a making a dictionary access.
Solution:   Parse the subscript even when not evaluating the sub-expression.
            (closes vim/vim#4704)
vim/vim@61343f0
seandewar added a commit to seandewar/neovim that referenced this pull request May 22, 2021
@seandewar
vim-patch:8.1.1722: error when scriptversion is 2 a making a dictiona…
52ec06d 
…ry access

Problem:    Error when scriptversion is 2 a making a dictionary access.
Solution:   Parse the subscript even when not evaluating the sub-expression.
            (closes vim/vim#4704)
vim/vim@61343f0
seandewar added a commit to seandewar/neovim that referenced this pull request Jun 2, 2021
@seandewar
vim-patch:8.1.1722: error when scriptversion is 2 a making a dictiona…
108dbb9 
…ry access

Problem:    Error when scriptversion is 2 a making a dictionary access.
Solution:   Parse the subscript even when not evaluating the sub-expression.
            (closes vim/vim#4704)
vim/vim@61343f0
seandewar added a commit to seandewar/neovim that referenced this pull request Jun 2, 2021
@seandewar
vim-patch:8.1.1722: error when scriptversion is 2 a making a dictiona…
4e6e52e 
…ry access

Problem:    Error when scriptversion is 2 a making a dictionary access.
Solution:   Parse the subscript even when not evaluating the sub-expression.
            (closes vim/vim#4704)
vim/vim@61343f0
seandewar added a commit to seandewar/neovim that referenced this pull request Jun 2, 2021
@seandewar
vim-patch:8.1.1722: error when scriptversion is 2 a making a dictiona…
2f1386b 
…ry access

Problem:    Error when scriptversion is 2 a making a dictionary access.
Solution:   Parse the subscript even when not evaluating the sub-expression.
            (closes vim/vim#4704)
vim/vim@61343f0
seandewar added a commit to seandewar/neovim that referenced this pull request Jun 3, 2021
@seandewar
vim-patch:8.1.1722: error when scriptversion is 2 a making a dictiona…
c21c974 
…ry access

Problem:    Error when scriptversion is 2 a making a dictionary access.
Solution:   Parse the subscript even when not evaluating the sub-expression.
            (closes vim/vim#4704)
vim/vim@61343f0
seandewar added a commit to seandewar/neovim that referenced this pull request Jun 5, 2021
@seandewar
vim-patch:8.1.1722: error when scriptversion is 2 a making a dictiona…
bcb19b5 
…ry access

Problem:    Error when scriptversion is 2 a making a dictionary access.
Solution:   Parse the subscript even when not evaluating the sub-expression.
            (closes vim/vim#4704)
vim/vim@61343f0
seandewar added a commit to seandewar/neovim that referenced this pull request Jun 25, 2021
@seandewar
vim-patch:8.1.1722: error when scriptversion is 2 a making a dictiona…
df3dedd 
…ry access

Problem:    Error when scriptversion is 2 a making a dictionary access.
Solution:   Parse the subscript even when not evaluating the sub-expression.
            (closes vim/vim#4704)
vim/vim@61343f0
seandewar added a commit to seandewar/neovim that referenced this pull request Jun 26, 2021
@seandewar
vim-patch:8.1.1722: error when scriptversion is 2 a making a dictiona…
e623fd7 
…ry access

Problem:    Error when scriptversion is 2 a making a dictionary access.
Solution:   Parse the subscript even when not evaluating the sub-expression.
            (closes vim/vim#4704)
vim/vim@61343f0
seandewar added a commit to seandewar/neovim that referenced this pull request Aug 26, 2021
@seandewar
vim-patch:8.1.1722: error when scriptversion is 2 a making a dictiona…
9b4ecf4 
…ry access

Problem:    Error when scriptversion is 2 a making a dictionary access.
Solution:   Parse the subscript even when not evaluating the sub-expression.
            (closes vim/vim#4704)
vim/vim@61343f0
seandewar added a commit to seandewar/neovim that referenced this pull request Aug 26, 2021
@seandewar
vim-patch:8.1.1722: error when scriptversion is 2 a making a dictiona…
ec1357f 
…ry access

Problem:    Error when scriptversion is 2 a making a dictionary access.
Solution:   Parse the subscript even when not evaluating the sub-expression.
            (closes vim/vim#4704)
vim/vim@61343f0
seandewar added a commit to seandewar/neovim that referenced this pull request Sep 10, 2021
@seandewar
vim-patch:8.1.1722: error when scriptversion is 2 a making a dictiona…
95b01bc 
…ry access

Problem:    Error when scriptversion is 2 a making a dictionary access.
Solution:   Parse the subscript even when not evaluating the sub-expression.
            (closes vim/vim#4704)
vim/vim@61343f0

:scriptversion is N/A.
seandewar added a commit to seandewar/neovim that referenced this pull request Sep 10, 2021
@seandewar
vim-patch:8.1.1722: error when scriptversion is 2 a making a dictiona…
39d3f8d 
…ry access

Problem:    Error when scriptversion is 2 a making a dictionary access.
Solution:   Parse the subscript even when not evaluating the sub-expression.
            (closes vim/vim#4704)
vim/vim@61343f0

:scriptversion is N/A.
seandewar added a commit to seandewar/neovim that referenced this pull request Sep 11, 2021
@seandewar
vim-patch:8.1.1722: error when scriptversion is 2 a making a dictiona…
dda977f 
…ry access

Problem:    Error when scriptversion is 2 a making a dictionary access.
Solution:   Parse the subscript even when not evaluating the sub-expression.
            (closes vim/vim#4704)
vim/vim@61343f0

:scriptversion is N/A.
lewis6991 pushed a commit to lewis6991/neovim that referenced this pull request Dec 12, 2021
@seandewar @lewis6991
vim-patch:8.1.1722: error when scriptversion is 2 a making a dictiona…
6260db7 
…ry access

Problem:    Error when scriptversion is 2 a making a dictionary access.
Solution:   Parse the subscript even when not evaluating the sub-expression.
            (closes vim/vim#4704)
vim/vim@61343f0

:scriptversion is N/A.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kuuote @codecov-io