Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9491 +/- ##
==========================================
+ Coverage 90.08% 90.40% +0.32%
==========================================
Files 154 154
Lines 173452 173439 -13
==========================================
+ Hits 156251 156796 +545
+ Misses 17201 16643 -558
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
|
Thanks for looking into this. When moving messages to errors.h I only added the most obvious #ifdefs. I was wondering what the best way was to do the rest. If you can do this with gcc that would be best. |
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Nov 14, 2022
Problem: Various code not used when features are disabled. Solution: Add #ifdefs. (Dominique Pellé, closes vim/vim#9491) vim/vim@748b308 N/A patches for version.c: vim-patch:8.2.2186: Vim9: error when using 'opfunc' Problem: Vim9: error when using 'opfunc'. Solution: Do not expect a return value from 'opfunc'. (closes vim/vim#7510) vim/vim@5b3d1bb
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Nov 14, 2022
Problem: Various code not used when features are disabled. Solution: Add #ifdefs. (Dominique Pellé, closes vim/vim#9491) vim/vim@748b308 N/A patches for version.c: vim-patch:8.2.2186: Vim9: error when using 'opfunc' Problem: Vim9: error when using 'opfunc'. Solution: Do not expect a return value from 'opfunc'. (closes vim/vim#7510) vim/vim@5b3d1bb
zeertzjq
added a commit
to neovim/neovim
that referenced
this pull request
Nov 14, 2022
…21049) Problem: Various code not used when features are disabled. Solution: Add #ifdefs. (Dominique Pellé, closes vim/vim#9491) vim/vim@748b308 N/A patches for version.c: vim-patch:8.2.2186: Vim9: error when using 'opfunc' Problem: Vim9: error when using 'opfunc'. Solution: Do not expect a return value from 'opfunc'. (closes vim/vim#7510) vim/vim@5b3d1bb
yesean
pushed a commit
to yesean/neovim
that referenced
this pull request
Mar 25, 2023
…eovim#21049) Problem: Various code not used when features are disabled. Solution: Add #ifdefs. (Dominique Pellé, closes vim/vim#9491) vim/vim@748b308 N/A patches for version.c: vim-patch:8.2.2186: Vim9: error when using 'opfunc' Problem: Vim9: error when using 'opfunc'. Solution: Do not expect a return value from 'opfunc'. (closes vim/vim#7510) vim/vim@5b3d1bb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ifdefout code which is not used.Unused function were found by compiling and linking with gcc options
-fdata-sections -ffunction-sections -Wl,--gc-sections,--print-gc-sections. gcc then reports unused functions at link time. I built vim with tiny/small/normal/big/huge features, with various guis and disabled unused code.Not done:
errors.h. I can do it as a separate PR if deemed useful enoughxdiff/*.cas whenFEAT_DIFFis not enabled.