Fix: remove the event.isUpdate check in controlling handler#931
Open
piotr-cz wants to merge 1 commit into
Open
Fix: remove the event.isUpdate check in controlling handler#931piotr-cz wants to merge 1 commit into
event.isUpdate check in controlling handler#931piotr-cz wants to merge 1 commit into
Conversation
✅ Deploy Preview for vite-plugin-pwa-legacy ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
event.isUpdate check in controlling handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The check for
event.isUpdateis preventing theonNeedReload()callback from being executed on first update.This event property indicates that it's an update to service worker that was available when workbox-window was registered.
In case of first update there wasn't a service worker at the time when Workbox has started, so it's value is
false.Full explanation and reproduction is in linked issue
Linked Issues
fixes #789