refactor(ssr): remove ssrTransform line offset preservation #19829
+199
−177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ecosystem-ci run |
commit: |
This comment was marked as outdated.
This comment was marked as outdated.
|
📝 Ran ecosystem CI on
✅ laravel, marko, ladle, astro, quasar, nuxt, previewjs, analogjs, react-router, qwik, histoire, rakkas, vite-plugin-react-swc, vite-plugin-pwa, sveltekit, vite-plugin-cloudflare, unocss, vite-plugin-vue, vite-plugin-svelte, vite-setup-catalogue, vuepress, vitest, vitepress |
|
I think we should wait merging this until next major as
|
sapphi-red
approved these changes
May 21, 2025
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially revert #19004 to remove line offset preservation logic as a minor simplification. This is not necessary anymore on Vitest after vitest-dev/vitest#7557 and this transform was also a best effort basis and didn't cover all scenarios (e.g. comments and exports in between).