fix(cli): make cleanGlobalCLIOptions() clean --force
#19999
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ecosystem-ci run |
sapphi-red
approved these changes
May 7, 2025
commit: |
|
📝 Ran ecosystem CI on
✅ analogjs, astro, ladle, marko, nuxt, quasar, qwik, previewjs, histoire, unocss, sveltekit, storybook, rakkas, waku, vite-plugin-react, vite-environment-examples, react-router, vite-plugin-vue, vite-plugin-svelte, vite-plugin-cloudflare, vite-plugin-pwa, vitepress, vite-setup-catalogue, vuepress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
cleanGlobalCLIOptions()does not clean theforceoption, causingserver.options.server.forceto be set to true when using the--forceflag, despite howserver.forceisn't supposed to be part of the API. I've created a repo to easily demonstrate the issue here.It seems like at one point
server.forcewas a part of the API, so not cleaning it was intentional. However, as the code evolved this was overlooked.