Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: skip checking private properties of typeParameters #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 16, 2024
Merged

fix: skip checking private properties of typeParameters #443

merged 4 commits into from
Sep 16, 2024
+7 −1

Conversation

edison1105
Copy link
Member

Description

fix vuejs/core#11923
The types imported from third-party libraries can be quite complex, and comparing them for equality is time-consuming.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@edison1105 edison1105 marked this pull request as draft September 14, 2024 03:01
@edison1105 edison1105 changed the title fix: skip the check typeParameters fix: skip checking some properties of typeParameters Sep 14, 2024
@edison1105 edison1105 marked this pull request as ready for review September 14, 2024 03:51
@edison1105 edison1105 mentioned this pull request Sep 14, 2024
Closed
@edison1105 edison1105 changed the title fix: skip checking some properties of typeParameters fix: skip checking private properties of typeParameters Sep 14, 2024
@hrubysimon hrubysimon mentioned this pull request Sep 15, 2024
Closed
@yyx990803 yyx990803 merged commit e4f5fff into vitejs:main Sep 16, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HMR takes a long time when extending/re-exporting types from external package
3 participants
@edison1105 @sxzz @yyx990803