Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(valid-title): report emptyTitle for string-like types #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2025
Merged

fix(valid-title): report emptyTitle for string-like types #688

merged 3 commits into from
Apr 2, 2025

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Apr 2, 2025 •
edited
Loading

Fixes: #687

Also updates the sample code in the documentation.

@y-hsgw y-hsgw changed the title fix(valid-title): no longer reports emptyTitle errors fix(valid-title): report emptyTitle for string-like types Apr 2, 2025
veritem
veritem approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@veritem veritem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@veritem veritem merged commit c1909ab into vitest-dev:main Apr 2, 2025
@y-hsgw y-hsgw deleted the fix/valid-title branch April 2, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veritem veritem veritem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

valid-title no longer reports emptyTitle errors since v1.1.38
2 participants
@y-hsgw @veritem