Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

egfx-notifications
Copy link
Contributor

Description

This PR adds the ability to use the Playwright browser provider with remote Playwright servers. Playwright itself doesn't support running on all distributions, it is primarily tested against Debian-based distributions. Notably Playwright doesn't support running on Red Hat Enterprise Linux and derived distributions. To solve this use case Playwright allows its client and server to run on different hosts, so the server may be launched on a supported distribution (see https://playwright.dev/docs/docker#remote-connection). By offering the client connect mode as an alternative to the launch mode we make browser mode available for more distributions.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 6fab0da
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6818c7927ab06e0008fc532e
😎 Deploy Preview https://deploy-preview-7915--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sheremet-va
sheremet-va previously approved these changes May 2, 2025
@egfx-notifications
Copy link
Contributor Author

I added a test for both the connect mode and the warning. Turned out starting a playwright server to test against isn't that difficult. Only using it for this specific test, though.

@egfx-notifications egfx-notifications force-pushed the feat/browser-mode-playwright-connect branch from 10145f9 to 287eebc Compare May 2, 2025 17:57
@egfx-notifications
Copy link
Contributor Author

Rebased onto main and force pushed to resolve conflicts with 573cb16#diff-d8daf1173a30a368d198d3a52ba85b83d0aed7c1927a33910f66cd746464ae04

sheremet-va
sheremet-va previously approved these changes May 5, 2025
@sheremet-va sheremet-va merged commit 029c078 into vitest-dev:main May 5, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants