Codestin Search App

Ujjwaljain16 · 2025-12-08T22:33:54Z

Description

When test.only is nested inside describe.only, only the test.only test should run, matching Mocha's behavior. Previously, all tests within the describe.only block would execute.

Resolves #9021

Changes:

Modified interpretTaskModes in packages/runner/src/utils/collect.ts to check for nested .only modifiers
When a suite has tasks with .only, only those specific tasks run (not all tasks from the parent describe.only)
Added test case test/core/test/nested-only.test.ts to verify the fix

Before (Bug):

describe.only('suite', () => {
  test.only('should run') //  Runs
  test('should NOT run')  //  Runs (incorrect)
})
// Result: Both tests run

After(Fixed):

describe.only('suite', () => {
  test.only('should run') //  Runs
  test('should NOT run')  // Skipped (correct)
})
// Result: Only test.only runs

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

Run the tests with pnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

netlify · 2025-12-08T22:36:04Z

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`f2eb5b6`
🔍 Latest deploy log	https://app.netlify.com/projects/vitest-dev/deploys/693c0fc7aa93280008e9c58d
😎 Deploy Preview	https://deploy-preview-9213--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

…t-dev#9021)

Ujjwaljain16 · 2025-12-08T23:07:13Z

The failing test boolean flag 100 should not crash CLI is unrelated to this PR. It's a coverage reporting issue on the main branch (likely from #9208). The test passes locally and this PR only modifies test filtering logic, not coverage reporting

Ujjwaljain16 · 2025-12-10T11:24:50Z

@sheremet-va requesting for reviews

This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/main/packages/coverage-v8#readme) ([source](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8)) | [`4.0.16` → `4.0.18`](https://renovatebot.com/diffs/npm/@vitest%2fcoverage-v8/4.0.16/4.0.18) | ![age](https://developer.mend.io/api/mc/badges/age/npm/@vitest%2fcoverage-v8/4.0.18?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@vitest%2fcoverage-v8/4.0.16/4.0.18?slim=true) | | [vitest](https://vitest.dev) ([source](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest)) | [`4.0.16` → `4.0.18`](https://renovatebot.com/diffs/npm/vitest/4.0.16/4.0.18) | ![age](https://developer.mend.io/api/mc/badges/age/npm/vitest/4.0.18?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/vitest/4.0.16/4.0.18?slim=true) | --- ### Release Notes <details> <summary>vitest-dev/vitest (@vitest/coverage-v8)</summary> ### [`v4.0.18`](https://github.com/vitest-dev/vitest/releases/tag/v4.0.18) [Compare Source](vitest-dev/vitest@v4.0.17...v4.0.18) ##### 🚀 Experimental Features - **experimental**: Add `onModuleRunner` hook to `worker.init` - by [@sheremet-va](https://github.com/sheremet-va) in [#9286](vitest-dev/vitest#9286) [<samp>(ea837)</samp>](vitest-dev/vitest@ea837de7d) ##### 🐞 Bug Fixes - Use `meta.url` in `createRequire` - by [@sheremet-va](https://github.com/sheremet-va) in [#9441](vitest-dev/vitest#9441) [<samp>(e0572)</samp>](vitest-dev/vitest@e057281ca) - **browser**: Hide injected data-testid attributes - by [@sheremet-va](https://github.com/sheremet-va) in [#9503](vitest-dev/vitest#9503) [<samp>(f8989)</samp>](vitest-dev/vitest@f89899cd8) - **ui**: Process artifact attachments when generating HTML reporter - by [@macarie](https://github.com/macarie) in [#9472](vitest-dev/vitest#9472) [<samp>(22543)</samp>](vitest-dev/vitest@225435647) ##### [View changes on GitHub](vitest-dev/vitest@v4.0.17...v4.0.18) ### [`v4.0.17`](https://github.com/vitest-dev/vitest/releases/tag/v4.0.17) [Compare Source](vitest-dev/vitest@v4.0.16...v4.0.17) ##### 🚀 Experimental Features - Support openTelemetry for browser mode - by [@hi-ogawa](https://github.com/hi-ogawa) in [#9180](vitest-dev/vitest#9180) [<samp>(1ec3a)</samp>](vitest-dev/vitest@1ec3a8b68) - Support TRACEPARENT and TRACESTATE environment variables for OpenTelemetry context propagation - by [@Copilot](https://github.com/Copilot), **hi-ogawa** and [@hi-ogawa](https://github.com/hi-ogawa) in [#9295](vitest-dev/vitest#9295) [<samp>(876cb)</samp>](vitest-dev/vitest@876cb84c2) ##### 🐞 Bug Fixes - Improve asymmetric matcher diff readability by unwrapping container matchers - by [@Copilot](https://github.com/Copilot), **sheremet-va**, **hi-ogawa** and [@hi-ogawa](https://github.com/hi-ogawa) in [#9330](vitest-dev/vitest#9330) [<samp>(b2ec7)</samp>](vitest-dev/vitest@b2ec724a8) - Improve runner error when importing outside of test context - by [@sheremet-va](https://github.com/sheremet-va) in [#9335](vitest-dev/vitest#9335) [<samp>(2dd3d)</samp>](vitest-dev/vitest@2dd3dd839) - Replace crypto.randomUUID to allow insecure environments (fix [#9](https://github.com/vitest-dev/vitest/issues/9)… - by [@plusgut](https://github.com/plusgut) in [#9339](vitest-dev/vitest#9339) and [#9](vitest-dev/vitest#9) [<samp>(e6a3f)</samp>](vitest-dev/vitest@e6a3f8cc7) - Handle null options in `addEventHandler` [#9371](vitest-dev/vitest#9371) - by [@ThibautMarechal](https://github.com/ThibautMarechal) in [#9372](vitest-dev/vitest#9372) and [#9371](vitest-dev/vitest#9371) [<samp>(40841)</samp>](vitest-dev/vitest@40841ff00) - Typo in browser.provider error - by [@deammer](https://github.com/deammer) in [#9394](vitest-dev/vitest#9394) [<samp>(4b67f)</samp>](vitest-dev/vitest@4b67fc25a) - **browser**: - Fix `process.env` and `import.meta.env` defines in inline project - by [@hi-ogawa](https://github.com/hi-ogawa) in [#9239](vitest-dev/vitest#9239) [<samp>(b70c9)</samp>](vitest-dev/vitest@b70c96121) - Fix upload File instance - by [@hi-ogawa](https://github.com/hi-ogawa) in [#9294](vitest-dev/vitest#9294) [<samp>(b6778)</samp>](vitest-dev/vitest@b67788c69) - Fix invalid project token for artifacts assets - by [@hi-ogawa](https://github.com/hi-ogawa) in [#9321](vitest-dev/vitest#9321) [<samp>(caa7d)</samp>](vitest-dev/vitest@caa7d73d4) - Log `ErrorEvent.message` when unhandled `ErrorEvent.error` is null - by [@hi-ogawa](https://github.com/hi-ogawa) in [#9322](vitest-dev/vitest#9322) [<samp>(5d84e)</samp>](vitest-dev/vitest@5d84eeb91) - Support `fileParallelism` on an instance - by [@sheremet-va](https://github.com/sheremet-va) in [#9328](vitest-dev/vitest#9328) [<samp>(15006)</samp>](vitest-dev/vitest@150065459) - **coverage**: - Remove unnecessary `istanbul-lib-source-maps` usage - by [@AriPerkkio](https://github.com/AriPerkkio) in [#9344](vitest-dev/vitest#9344) [<samp>(b0940)</samp>](vitest-dev/vitest@b09405375) - Apply patch from [istanbuljs/istanbuljs#837](istanbuljs/istanbuljs#837) - by [@AriPerkkio](https://github.com/AriPerkkio) and **sapphi-red** in [#9413](vitest-dev/vitest#9413) and [#837](vitest-dev/vitest#837) [<samp>(e05ce)</samp>](vitest-dev/vitest@e05cedbf4) - **fsModuleCache**: - Don't store importers in cache - by [@sheremet-va](https://github.com/sheremet-va) in [#9422](vitest-dev/vitest#9422) [<samp>(75136)</samp>](vitest-dev/vitest@751364eec) - Add importers alongside importedModules - by [@sheremet-va](https://github.com/sheremet-va) in [#9423](vitest-dev/vitest#9423) [<samp>(59f92)</samp>](vitest-dev/vitest@59f92d403) - **mocker**: - Fix mock transform with class - by [@hi-ogawa](https://github.com/hi-ogawa) in [#9421](vitest-dev/vitest#9421) [<samp>(d390e)</samp>](vitest-dev/vitest@d390eb527) - **pool**: - Validate environment options when reusing the worker - by [@sheremet-va](https://github.com/sheremet-va) in [#9349](vitest-dev/vitest#9349) [<samp>(a8a88)</samp>](vitest-dev/vitest@a8a8836e3) - Handle worker start failures gracefully - by [@AriPerkkio](https://github.com/AriPerkkio) in [#9337](vitest-dev/vitest#9337) [<samp>(200da)</samp>](vitest-dev/vitest@200dadb32) - **reporter**: - Report test module if it failed to run - by [@sheremet-va](https://github.com/sheremet-va) in [#9272](vitest-dev/vitest#9272) [<samp>(c7888)</samp>](vitest-dev/vitest@c78882985) - **runner**: - Respect nested test.only within describe.only - by [@Ujjwaljain16](https://github.com/Ujjwaljain16) in [#9021](vitest-dev/vitest#9021) and [#9213](vitest-dev/vitest#9213) [<samp>(55d5d)</samp>](vitest-dev/vitest@55d5dad69) - **typecheck**: - Improve error message when tsc outputs help text - by [@Ujjwaljain16](https://github.com/Ujjwaljain16) in [#9214](vitest-dev/vitest#9214) [<samp>(7b10a)</samp>](vitest-dev/vitest@7b10ab4cd) - **ui**: - Detect gzip by magic numbers instead of Content-Type header in html reporter - by [@Copilot](https://github.com/Copilot), **hi-ogawa** and [@hi-ogawa](https://github.com/hi-ogawa) in [#9278](vitest-dev/vitest#9278) [<samp>(dd033)</samp>](vitest-dev/vitest@dd0331632) - **webdriverio**: - Fall back to WebDriver Classic [#9244](vitest-dev/vitest#9244) - by [@JustasMonkev](https://github.com/JustasMonkev) in [#9373](vitest-dev/vitest#9373) and [#9244](vitest-dev/vitest#9244) [<samp>(c23dd)</samp>](vitest-dev/vitest@c23dd11bd) ##### [View changes on GitHub](vitest-dev/vitest@v4.0.16...v4.0.17) </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM, on day 1 of the month ( * 0-3 1 * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11121 Reviewed-by: Gusted <[email protected]> Reviewed-by: Michael Kriese <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

fix(runner): respect nested test.only within describe.only (fix vites…

fba5ac8

…t-dev#9021)

Ujjwaljain16 force-pushed the fix/nested-only-tests-9021 branch from 2a5755b to fba5ac8 Compare December 8, 2025 22:47

Merge branch 'main' into fix/nested-only-tests-9021

8c51b53

Ujjwaljain16 added 2 commits December 10, 2025 21:51

Merge branch 'main' into fix/nested-only-tests-9021

391f15b

Merge branch 'main' into fix/nested-only-tests-9021

f2eb5b6

sheremet-va approved these changes Dec 17, 2025

View reviewed changes

sheremet-va merged commit 55d5dad into vitest-dev:main Dec 17, 2025
12 of 16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(runner): respect nested test.only within describe.only (fix #9021)#9213

fix(runner): respect nested test.only within describe.only (fix #9021)#9213
sheremet-va merged 4 commits intovitest-dev:mainfrom
Ujjwaljain16:fix/nested-only-tests-9021

Ujjwaljain16 commented Dec 8, 2025 •

edited

Loading

Uh oh!

netlify bot commented Dec 8, 2025 •

edited

Loading

Uh oh!

Ujjwaljain16 commented Dec 8, 2025

Uh oh!

Ujjwaljain16 commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Ujjwaljain16 commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Documentation

Changesets

Uh oh!

netlify bot commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vitest-dev ready!

Uh oh!

Ujjwaljain16 commented Dec 8, 2025

Uh oh!

Ujjwaljain16 commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Ujjwaljain16 commented Dec 8, 2025 •

edited

Loading

netlify bot commented Dec 8, 2025 •

edited

Loading