Fix out kwarg shape check with ngroups swapped#4
Merged
Conversation
WoosukKwon
approved these changes
May 31, 2024
JongYeop-IDSLab
added a commit
to IDSLab-SKKU/IDS-flash-attention
that referenced
this pull request
Jun 1, 2026
… race UNRESOLVED) Attempted fixes vllm-project#2/vllm-project#3 for the long-context non-deterministic race in the d=128 QK CoFDA emulation: IntraWGOverlap=!UseQKEmu and UsePersistentScheduler=!UseQKEmu (route the synchronous emu through the simpler non-overlapped / single-tile path). BOTH INEFFECTIVE — the race persists with an identical pattern, so the cause is NOT the overlap pipeline or the persistent scheduler. Working theory: a per-gemm smem read race inside gemm_qk_cofda_emu vs the async TMA producer. Stopped per systematic-debugging Iron Law (no fix vllm-project#4 without re-think). Race scales with total emu QK-gemm calls (M_blocks x KV_blocks); bit-exact for short context. Full handoff + repro: vllm-mma/cair/experiments/docs/qk-emu-longcontext-race-debug.md Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed this case