⚙️ - Void version from : tag (semver) commit and date#279
Merged
andrewpareles merged 47 commits intovoideditor:mainfrom Mar 21, 2025
Merged
⚙️ - Void version from : tag (semver) commit and date#279andrewpareles merged 47 commits intovoideditor:mainfrom
andrewpareles merged 47 commits intovoideditor:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 7bcecee in 2 minutes and 8 seconds
More details
- Looked at
167lines of code in5files - Skipped
0files when reviewing. - Skipped posting
5drafted comments based on config settings.
1. product.json:40
- Draft comment:
Add a newline at the end of product.json to follow best practices. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
While having a newline at the end of files is indeed a common best practice, this kind of formatting issue is typically handled by automated formatters and linters. It's a very minor issue that doesn't affect functionality. The rules state we should not make purely informative comments or obvious/unimportant ones.
The missing newline could cause issues with some tools or in some development environments. It's a widely accepted Unix convention.
While true, this is exactly the kind of issue that should be handled by automated tooling rather than manual review comments. If it's important to the project, it should be enforced by a linter.
The comment should be deleted as it's too minor for a manual review comment and would be better handled by automated tooling.
2. src/vs/workbench/electron-sandbox/parts/dialogs/dialogHandler.ts:85
- Draft comment:
Verify that the localization message correctly maps voidVersion and VSCode version; the new order may be confusing for translators. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%
None
3. package.json:79
- Draft comment:
Consider cross-platform compatibility: the inline shell commands (e.g. using $(...)) may not work on Windows. Use a cross-platform solution or document the intended environment. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50%
The scripts are development tooling scripts for version bumping, not core functionality. The team likely has a standard development environment. The $(...) syntax is used in many other existing scripts in package.json. If Windows compatibility was a requirement, it would likely have been standardized already. Making everything cross-platform compatible would add complexity for potentially little benefit.
The comment identifies a real technical issue - the scripts won't work on Windows PowerShell. This could cause problems if any team members use Windows for development.
While technically correct, this seems like an overly cautious concern for development scripts. The existing codebase already uses this pattern extensively, suggesting the team has accepted this limitation.
The comment should be deleted. While technically accurate, it raises a minor compatibility issue that the project has already implicitly accepted in its other scripts. The benefit of cross-platform compatibility doesn't justify the added complexity for these development-only scripts.
4. scripts/update-version.js:14
- Draft comment:
It's advisable to wrap execSync('git rev-parse HEAD') in a try/catch block to handle potential errors when the git command fails. - Reason this comment was not posted:
Marked as duplicate.
5. src/vs/workbench/electron-sandbox/parts/dialogs/dialogHandler.ts:85
- Draft comment:
Verify that the localization string placeholders match the intended order. The new about text now shows 'Void' version first followed by VSCode version; ensure this order is correct for all locales. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
The comment is asking the PR author to verify the order of localization string placeholders, which is against the rules as it asks for confirmation of intention. It does not provide a specific suggestion or point out a clear issue that needs addressing.
Workflow ID: wflow_S7KEIycqgpUtmBvi
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
- Send Mistral chat to fix [error 422]
Feat mistral 199
let try this. Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Contributor
Author
|
@andrewpareles : this is also working nicely and does not make conflicts (updated today) |
Contributor
|
Nice work on this - going to manually change the version for now :), but this is super helpful. When we add CI/CD will look at the bump scripts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows consistent auto-version numbering into the dialogHandler,
Everything is done with an automated tag / hash / date creation. running
npm run void-version-patchnpm run void-version-minornpm run void-version-majorThis fix #248
And this is not touching the version numbering used by vscode. So this should not interfere with marketplace.
Important
Automates versioning in
product.jsonwith new scripts and updatesNativeDialogHandlerto displayvoidVersion.void-version-patch,void-version-minor, andvoid-version-majorinpackage.json.product.jsonwithvoidVersion,commit, anddateusingscripts/update-version.js.NativeDialogHandlerindialogHandler.tsnow displaysvoidVersionin the about dialog.update-version.jsupdatesvoidVersion,commit, anddateinproduct.json.voidVersiontoIProductConfigurationinproduct.ts.This description was created by
for 7bcecee. It will automatically update as commits are pushed.