fix ENOENT error spawn on Windows#284
Merged
andrewpareles merged 1 commit intovoideditor:mainfrom Feb 15, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 1839aca in 43 seconds
More details
- Looked at
26lines of code in2files - Skipped
1files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. package.json:112
- Draft comment:
Ensure dependency lock for cross-spawn version if strict version compatibility is needed. - Reason this comment was not posted:
Confidence changes required:10%<= threshold50%
None
2. src/vs/workbench/contrib/void/browser/react/build.js:7
- Draft comment:
Using cross-spawn provides cross-platform support, but ensure argument quoting works as expected on Windows. - Reason this comment was not posted:
Confidence changes required:20%<= threshold50%
None
3. package.json:110
- Draft comment:
Cross-spawn was added to fix Windows spawn issues. If build.js is only used during development, consider moving this dependency to devDependencies. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
4. src/vs/workbench/contrib/void/browser/react/build.js:7
- Draft comment:
Good use of cross-spawn for improved Windows compatibility. For consistency, consider adding a semicolon at the end of the import statement. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
Workflow ID: wflow_iCP3HWA3gMbhkPGl
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Contributor
|
Nice fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request was made to handle the following ENOENT error:
To fix this, I use cross-spawn, a popular npm package to handle cross platform spawns and it fixed this issue.
The only change that was made was to install
cross-spawnand changed thespawnimport fromchild_processtocross-spawnin thebuild.jsfile.Everything works fine after that and the application ran, and the watch feature in Windows works great.
Important
Fixes ENOENT error on Windows by using
cross-spawnfor process spawning inbuild.js.child_process.spawnwithcross-spawninbuild.js.cross-spawntopackage.jsondependencies.spawnimport fromchild_processtocross-spawninbuild.js.This description was created by
for 1839aca. It will automatically update as commits are pushed.