feat: use npm instead of yarn#30
Merged
mathewpareles merged 3 commits intovoideditor:mainfrom Sep 19, 2024
Merged
Conversation
8d4077f to
e1b116c
Compare
Contributor
|
Any idea how to do nonlocal imports with npm @deepak1556 or @quant-eagle? If you could help me do a PR where void.contribution.ts simply imports 'openai' and prints it out, that'd be a ton of help right now. I'm getting in touch because it looks like migrating from yarn to npm makes imports a lot more difficult. I spent a lot of time trying to import 'openai' in void.contribution.ts, and am considering reverting to yarn because I think it'd be easier. Let me know what you think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR transitions the project from Yarn to npm for package management. This change aligns with the decision by the VS Code maintainers to move away from Yarn. Npm has caught up in features, notably with automatic peer dependency installation (npm 7+), and Yarn v1 is no longer actively maintained.
Changes
yarn.lockand generated a newpackage-lock.json.Why is this needed?
Yarn v1 has become outdated, while npm now provides similar functionality and better long-term support. This transition aligns with the upstream VS Code repository to ease integration and reduce maintenance efforts.
Checklist
yarn.lockand generatedpackage-lock.json.Testing
Ensure that all contributors are using npm, and that the project builds and tests run successfully with the new package manager.
Additional Information
Switching to npm helps keep this fork aligned with VS Code upstream, ensuring smoother dependency management and long-term stability. Should you face any issues, please report them for resolution.