Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rebase vscode into Void#66

Merged
andrewpareles merged 3 commits intomainfrom
rebase
Sep 30, 2024
Merged

Rebase vscode into Void#66
andrewpareles merged 3 commits intomainfrom
rebase

Conversation

@andrewpareles
Copy link
Contributor

@andrewpareles andrewpareles commented Sep 24, 2024 •
edited by ghost
Loading

Summary by Honeycomb

This pull request makes several changes to the VS Code codebase, primarily focusing on notebook-related functionality and ESLint rules. It introduces new features, modifies existing ones, and updates various configurations.

Details

Note

🍯 This summary was generated with Honeycomb for #66.
Leave feedback here: https://app.honeycomb.sh/dashboard/sessions/ses-a5473e32-021e-4108-92d2-3e42747b8e6c.

Key Changes

.dependencygraph/setting.json

  • File has been deleted entirely

.eslintplugin/code-ensure-no-disposables-leak-in-test.ts

  • Added 'fixable' property to the rule definition
  • Implemented a fix function to automatically add ensureNoDisposablesAreLeakedInTestSuite() call to test suites

.eslintplugin/code-import-patterns.ts

  • Added 'hasElectron' condition to import patterns
  • Introduced 'electron-utility' as a new layer
  • Added checks for ESM compatibility (relative imports and .js/.css extensions)
  • Updated import restrictions for VS Code-specific files

.eslintplugin/code-no-look-behind-regex.ts

  • File has been deleted entirely

src/vs/workbench/contrib/notebook/browser/contrib/notebookVariables/notebookVariables.ts

  • Added new imports for various notebook-related components
  • Implemented NotebookMetadataContentProvider class for handling notebook metadata
  • Updated CellInfoContentProvider to use transient metadata options
  • Added registration for NotebookMetadataContentProvider and NotebookOutlineEntryFactory
  • Introduced new configuration for multi-cursor support in notebooks

@andrewpareles andrewpareles self-assigned this Sep 24, 2024
@ghost
Copy link

ghost commented Sep 24, 2024

Note

🍯 Honeycomb is reviewing your code. This may take a few minutes.

Track Honeycomb's progress at: https://app.honeycomb.sh/dashboard/sessions/ses-7afa328d-c80a-4877-8dfa-869e709fd163.

This comment will automatically be updated when Honeycomb finishes.

Tips

Honeycomb PR Commands

To invoke these commands, use them in a PR comment.

  • @honeycomb review: Start a code review.
  • @honeycomb summarize: Summarize a pull request.
  • @honeycomb document: Generate documentation. This will create a new PR.
  • @honeycomb test: Create unit tests. This will create a new PR.

Honeycomb Issue Commands

To invoke these commands, use them in an issue comment.

  • @honeycomb solve: Initiate a coding session.
  • @honeycomb fix: Begin a bugfix session.
  • @honeycomb plan: Create a development plan.

Configure Settings

Configure automatic session settings at https://app.honeycomb.sh/dashboard/session-settings.

Documentation and Feedback

  • Visit our documentation at https://docs.honeycomb.sh for more details on how to use Honeycomb.
  • Follow us on Twitter for updates: https://x.com/honeycombsh.
  • Leave feedback at the end of each session to help us improve, by clicking on the session link or accessing the session through the dashboard.
  • For direct support or inquiries, reach out to us at [email protected]

@andrewpareles andrewpareles merged commit 6dac962 into main Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@andrewpareles andrewpareles

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@andrewpareles