Added displaying error messages in UI#87
Merged
andrewpareles merged 9 commits intovoideditor:mainfrom Oct 18, 2024
w1gs:main
Merged
Added displaying error messages in UI#87andrewpareles merged 9 commits intovoideditor:mainfrom w1gs:main
andrewpareles merged 9 commits intovoideditor:mainfrom
w1gs:main
Conversation
Hieuuuu96
reviewed
Oct 5, 2024
Contributor
|
What autoformatter are you using? |
Contributor
Author
I used prettier with the configuration mentioned in #72. I could revert it if needed. |
Contributor
|
Will merge this shortly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds error messages in the extension UI. This should make it easier for new users to understand why a request has failed. This should also handle aborting correctly so if there are any errors, the UI features that depend on aborted connections (like resetting the state of the send button from the 'stop' state) also get updated.
Examples:
