fixed dependencies that were preventing IDE builds#92
Merged
andrewpareles merged 2 commits intovoideditor:mainfrom Oct 11, 2024
w1gs:ide-fixes
Merged
fixed dependencies that were preventing IDE builds#92andrewpareles merged 2 commits intovoideditor:mainfrom w1gs:ide-fixes
andrewpareles merged 2 commits intovoideditor:mainfrom
w1gs:ide-fixes
Conversation
Contributor
|
@andrewpareles The fix worked perfectly ! Thank you @w1gs I am giving me a little pause to write some documentation for Mac OS ARM ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues that were preventing the full IDE from being built. Mainly the
original-fsdependency was added as it's required in theout/bootstrap-amd.jsfile. Additionally, it moves thediffdev dependency in the extension to the main extension dependencies since this was preventing the extension from loading in the compiled IDE.Error in compiled IDE related to
diffpackage:Code where
original-fsdependency is required: