do not validate is_sorted on runend#6025
Conversation
Signed-off-by: Onur Satici <[email protected]>
Signed-off-by: Onur Satici <[email protected]>
Signed-off-by: Onur Satici <[email protected]>
Merging this PR will degrade performance by 24.91%
Performance Changes
Comparing 
Footnotes
|
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Onur Satici <[email protected]>
Signed-off-by: Onur Satici <[email protected]>
| if v < offset_e { | ||
| vortex_panic!("run end {v} must be >= offset {offset}"); | ||
| } |
There was a problem hiding this comment.
checked - and expect?
There was a problem hiding this comment.
yea I tried checked sub but that also has the same branch so not much perf improvement, but I can do that here would be cleaner
There was a problem hiding this comment.
Just think it read better
assert no invalid memory access will happen on decoding time instead. I think with #6024 we won't hit this with new files, but there is nothing preventing this to come back when we add a new encoding into the mix, and this will also speed up decoding old files that didn't have the stat propagated --------- Signed-off-by: Onur Satici <[email protected]>
assert no invalid memory access will happen on decoding time instead.
I think with #6024 we won't hit this with new files, but there is nothing preventing this to come back when we add a new encoding into the mix, and this will also speed up decoding old files that didn't have the stat propagated