Fix: dont do lazy filters on write#6194
Merged
connortsui20 merged 2 commits intodevelopfrom Jan 28, 2026
Merged
Conversation
Signed-off-by: Connor Tsui <[email protected]>
CodSpeed Performance ReportMerging this PR will degrade performance by 29.85%Comparing Summary
Performance ChangesFootnotes
|
whoops Signed-off-by: Connor Tsui <[email protected]>
Contributor
|
This fixes @delta003 's issue on Spiral 4046. |
Contributor
Benchmarks: Random AccessSummary
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Deploying vortex-bench with
|
| Latest commit: |
4d13e23
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://64927595.vortex-93b.pages.dev |
| Branch Preview URL: | https://dk-vortex-for-mb-clients.vortex-93b.pages.dev |
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
danking
approved these changes
Jan 28, 2026
a10y
pushed a commit
that referenced
this pull request
Jan 28, 2026
This should fix the CI failures right now. More detailed discussion that I'll write incoming... Basically we shouldn't be eagerly decompressing validity when filtering it, but for now to make sure things aren't broken this will have to do. Edit: This should fix the break on spiral as well @delta003, as reported by @danking --------- Signed-off-by: Connor Tsui <[email protected]>
danking
pushed a commit
that referenced
this pull request
Feb 6, 2026
This should fix the CI failures right now. More detailed discussion that I'll write incoming... Basically we shouldn't be eagerly decompressing validity when filtering it, but for now to make sure things aren't broken this will have to do. Edit: This should fix the break on spiral as well @delta003, as reported by @danking --------- Signed-off-by: Connor Tsui <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the CI failures right now.
More detailed discussion that I'll write incoming...
Basically we shouldn't be eagerly decompressing validity when filtering it, but for now to make sure things aren't broken this will have to do.
Edit: This should fix the break on spiral as well @delta003, as reported by @danking