aggregate fns to have grouped aggregate kernels for sum and count#8314
Merged
Conversation
4337366 to
4fd94bc
Compare
Signed-off-by: Onur Satici <[email protected]>
joseph-isaacs
left a comment
Contributor
There was a problem hiding this comment.
This seems like a good idea
4fd94bc to
7b85f05
Compare
Merging this PR will improve performance by ×4.3
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | count_i32_clustered_nulls |
641.9 µs | 55.2 µs | ×12 |
| ⚡ | Simulation | sum_i32_clustered_nulls |
545.4 µs | 71.8 µs | ×7.6 |
| ⚡ | Simulation | sum_i32_nullable_all_valid |
335.5 µs | 73.4 µs | ×4.6 |
| ⚡ | Simulation | count_varbinview |
252.5 µs | 75.8 µs | ×3.3 |
| ⚡ | Simulation | encode_varbin[(1000, 2)] |
175.4 µs | 158 µs | +11.06% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing os/grouped-agg (5d009d0) with develop (1082a5d)
Signed-off-by: Onur Satici <[email protected]>
Signed-off-by: Onur Satici <[email protected]>
Signed-off-by: Onur Satici <[email protected]>
onursatici
commented
Jun 9, 2026
| /// Explicit ranges extracted from a list-view array. | ||
| ListView { | ||
| /// The `(offset, size)` ranges. | ||
| ranges: Vec<(usize, usize)>, |
Contributor
Author
There was a problem hiding this comment.
I did try making this lazy but it didn't help much, it is faster but not clear if it is faster across the board
Signed-off-by: Onur Satici <[email protected]>
joseph-isaacs
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aggregate functions to be able to do grouped aggregations before the fallback that slices group by group.
Implements count for all arrays and sum for primitives.
API Changes
Grouped aggregate kernels now receive a single
GroupedArrayenum, coveringListViewArrayandFixedSizeListArray, instead of exposing separate methods for each list representation