Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Json-Variant exprs#8391

Draft
AdamGS wants to merge 3 commits into
developfrom
adamg/variant-json-handling
Draft

Json-Variant exprs#8391
AdamGS wants to merge 3 commits into
developfrom
adamg/variant-json-handling

Conversation

@AdamGS

@AdamGS AdamGS commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Supersedes #8156

@AdamGS AdamGS mentioned this pull request Jun 12, 2026
Closed
@AdamGS AdamGS force-pushed the adamg/variant-json-handling branch from 860196c to b9ae199 Compare June 12, 2026 16:27
@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 1542 untouched benchmarks
⏩ 10 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation varbinview_large 113.4 µs 131.2 µs -13.57%
⚡ Simulation take_map[(0.1, 0.5)] 1,180.4 µs 979.1 µs +20.56%
⚡ Simulation take_map[(0.1, 1.0)] 1.9 ms 1.7 ms +14.48%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing adamg/variant-json-handling (0bc0405) with develop (4b867a0)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@AdamGS AdamGS force-pushed the adamg/variant-json-handling branch 2 times, most recently from b5d833f to 3e823bc Compare June 17, 2026 11:29
AdamGS added 3 commits June 17, 2026 12:30
@AdamGS
Json-Variant exprs
83b0b7c 
Signed-off-by: Adam Gutglick <[email protected]>
@AdamGS
Fix thing
488edb5 
Signed-off-by: Adam Gutglick <[email protected]>
@AdamGS
some fixes
0bc0405 
Signed-off-by: Adam Gutglick <[email protected]>
@AdamGS AdamGS force-pushed the adamg/variant-json-handling branch from 3e823bc to 0bc0405 Compare June 17, 2026 11:30
@AdamGS AdamGS added the changelog/feature A new feature label Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog/feature A new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AdamGS