feat(vortex-datafusion): push st_distance into the scan as GeoDistance#8455
feat(vortex-datafusion): push st_distance into the scan as GeoDistance#8455HarukiMoriarty wants to merge 2 commits into
Conversation
Signed-off-by: Nemo Yu <[email protected]>
Signed-off-by: Nemo Yu <[email protected]>
23526c7 to
d842e32
Compare
Merging this PR will degrade performance by 26.96%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_bool_canonical_into[(1000, 10)] |
20.4 µs | 35.5 µs | -42.54% |
| ❌ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
161.7 µs | 197.9 µs | -18.3% |
| ❌ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
176.8 µs | 213 µs | -17% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing nemo/spatialbench-q1 (d842e32) with nemo/geo-q1 (46c1d5c)
Footnotes
-
10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Status: blocked on upstream geodatafusion
Adds a temporary dependency on the geodatafusion fork
HarukiMoriarty/geodatafusion@3d50d7e(manually bumped to DataFusion 54).Not for merge as-is. Unblocks when geodatafusion publishes a DataFusion-54 release on crates.io; the git dep then swaps to a version and this un-drafts.
Stacks on #8453.
Summary
Recognizes geodatafusion's
st_distanceduring DataFusion → Vortex expression conversion and pushes it into the scan as a nativeGeoDistanceexpression, instead of letting it run row-by-row above the scan.