Replace deprecated create_resources() with native puppet#236
Open
bastelfreak wants to merge 1 commit into
Open
Replace deprecated create_resources() with native puppet#236bastelfreak wants to merge 1 commit into
create_resources() with native puppet#236bastelfreak wants to merge 1 commit into
Conversation
d53cbd4 to
1e37334
Compare
create_resources() is a legacy pattern. It messes with the ordering in the catalog. We can replace it with native puppet code.
create_resources() with native puppet
kenyon
reviewed
Nov 13, 2025
| create_resources(powerdns::config, $powerdns_auth_config, $powerdns_auth_defaults) | ||
| $powerdns_auth_config.each |$conf_title, $data| { | ||
| powerdns::config { $conf_title: | ||
| * => $data + { 'type' => 'authoritative' }, |
Member
There was a problem hiding this comment.
Shouldn't $data override the defaults?
Suggested change
| * => $data + { 'type' => 'authoritative' }, | |
| * => { 'type' => 'authoritative' } + $data, |
Member
Author
There was a problem hiding this comment.
good idea. I need to check how create_resources() merged it.
Member
There was a problem hiding this comment.
The third argument to create_resources is the defaults hash: https://help.puppet.com/core/8/Content/PuppetCore/Markdown/function.htm#create_resources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_resources() is a legacy pattern. It messes with the ordering in the catalog. We can replace it with native puppet code.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues