Fix horizontal scroll in child element on IOS #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows for short circuiting the `hasAnyScrollableEl` function if it finds a scrollable element and stop checking parents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current implementation of
useLockScrollchild elements withoverflow-xof'auto' | 'scroll'on IOS are prevented and scrolling in these panels do not function well. I only found this as an issue with IOS.The modifications here will check for both
XandYoverflow on the parent elements of the event target.You can see an example on an IOS device here https://stackblitz.com/edit/github-s2cpc5?file=src%2Fcomponents%2FMyModal.vue
based on willmcpo/body-scroll-lock#133