-
-
Notifications
You must be signed in to change notification settings - Fork 121
feat: add vScope
#357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AliceLanniste
wants to merge
17
commits into
vue-macros:main
Choose a base branch
from
AliceLanniste:feat-vScope
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add vScope
#357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🦋 Changeset detectedLatest commit: e194d62 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@AliceLanniste I just simplified the code a lot and pushed it (force). Don't forget to reset to the latest commit. |
e77b26a
to
4325165
Compare
c9889a2
to
6307026
Compare
b1890fb
to
999d6ff
Compare
fa5aca8
to
037079f
Compare
0ec37a2
to
b55fa5a
Compare
406889e
to
7dedf40
Compare
440a7b0
to
e9d2b1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have now implemented the v-scope directive, which supports nested directives and single directive.I will refactor later.I have no idea about
if
andfor
condition. If you get an idea,we can discusss.Linked Issues
closes #146
Additional context