Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(compiler): make transform bare bool optional #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2025
Merged

refactor(compiler): make transform bare bool optional #299

merged 2 commits into from
Aug 1, 2025

Conversation

ShenQingchuan
Copy link
Member

@ShenQingchuan ShenQingchuan commented Aug 1, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Added a new "Boolean Cast" page, accessible via navigation and routing, to demonstrate and test boolean attribute casting in components.

  • Bug Fixes

    • Improved handling of bare attribute boolean transformation, providing more explicit control and refined behavior for boolean props.

  • Tests

    • Introduced new test coverage to verify correct transformation of bare attributes as boolean values.

  • Refactor

    • Reorganized and renamed internal compiler options for template transforms to enhance clarity and separation of concerns.
    • Adjusted the order of embedded virtual codes to ensure compatibility with editor features.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 1, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

This change refactors the handling of Vue template transform options, introducing more granular control for boolean attribute and asset URL transformations. It updates option structures and function signatures, adds a new test and fixture for boolean casting, and adjusts the order of embedded codes in the language service to improve Emmet support.

Changes

Cohort / File(s) Change Summary
Compiler Option Refactor
packages/compiler/src/template/compose.ts, packages/compiler/src/types.ts, packages/language-service/src/vine-ctx.ts		 Refactored compiler options for template transforms: replaced __transformNegativeBool with __enableTransformBareAttrAsBool, updated function signatures, and separated boolean and asset URL transform logic into distinct helpers and options.
E2E Test: Boolean Cast Feature
packages/e2e-test/src/app.vine.ts, packages/e2e-test/src/fixtures/boolean-cast.vine.ts, packages/e2e-test/src/router.ts, packages/e2e-test/tests/basic.spec.ts		 Added a new route, fixture component, and test for verifying boolean attribute casting in templates.
Language Service: Embedded Code Order
packages/language-service/src/virtual-code.ts		 Changed the order of embedded codes to yield template HTML first, preserving Emmet functionality.

Sequence Diagram(s)

sequenceDiagram
    participant App as App
    participant Router as Router
    participant MyComp as MyComp (Fixture)
    participant Compiler as Compiler

    App->>Router: Navigate to /boolean-cast
    Router->>MyComp: Render TestBoolCastPage
    MyComp->>Compiler: Compile template with boolean attributes
    Compiler-->>MyComp: Transform bare attrs as bool (controlled by new options)
    MyComp-->>App: Rendered output with correct boolean casting
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15-20 minutes

Assessment against linked issues

Objective Addressed Explanation
Boolean attribute handling in templates should be correct (h-65px not working, #296) ✅
Compiler options should support fine-grained control for boolean attribute transformation (#296) ✅
No changes for unrelated features (e.g., AttributifyJSX, transformerDirectives, etc.) (#296) ✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Possibly related PRs

Poem

A hop, a skip, a boolean cast,
Now attributes are sorted, fast!
With routes and tests for every case,
Emmet’s smile lights up the place.
Options split, transforms anew—
This bunny’s proud of what you do! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 218bc48 and eea385a.

📒 Files selected for processing (8)
  • packages/compiler/src/template/compose.ts (3 hunks)
  • packages/compiler/src/types.ts (1 hunks)
  • packages/e2e-test/src/app.vine.ts (1 hunks)
  • packages/e2e-test/src/fixtures/boolean-cast.vine.ts (1 hunks)
  • packages/e2e-test/src/router.ts (2 hunks)
  • packages/e2e-test/tests/basic.spec.ts (1 hunks)
  • packages/language-service/src/vine-ctx.ts (1 hunks)
  • packages/language-service/src/virtual-code.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/next-minor-v1-7-0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ShenQingchuan ShenQingchuan merged commit e55cfb2 into main Aug 1, 2025
5 of 6 checks passed
@netlify Netlify
Copy link

netlify bot commented Aug 1, 2025 •
edited
Loading

✅ Deploy Preview for vue-vine ready!

Name Link
🔨 Latest commit eea385a
🔍 Latest deploy log https://app.netlify.com/projects/vue-vine/deploys/688cc5c930aeb000082a88a9
😎 Deploy Preview https://deploy-preview-299--vue-vine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ShenQingchuan ShenQingchuan deleted the feat/next-minor-v1-7-0 branch August 1, 2025 13:49
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 1, 2025

Open in StackBlitz

@vue-vine/compiler

npm i https://pkg.pr.new/vue-vine/vue-vine/@vue-vine/compiler@299

create-vue-vine

npm i https://pkg.pr.new/vue-vine/vue-vine/create-vue-vine@299

@vue-vine/eslint-config

npm i https://pkg.pr.new/vue-vine/vue-vine/@vue-vine/eslint-config@299

@vue-vine/eslint-parser

npm i https://pkg.pr.new/vue-vine/vue-vine/@vue-vine/eslint-parser@299

@vue-vine/eslint-plugin

npm i https://pkg.pr.new/vue-vine/vue-vine/@vue-vine/eslint-plugin@299

@vue-vine/language-server

npm i https://pkg.pr.new/vue-vine/vue-vine/@vue-vine/language-server@299

@vue-vine/language-service

npm i https://pkg.pr.new/vue-vine/vue-vine/@vue-vine/language-service@299

@vue-vine/nuxt

npm i https://pkg.pr.new/vue-vine/vue-vine/@vue-vine/nuxt@299

vue-vine-tsc

npm i https://pkg.pr.new/vue-vine/vue-vine/vue-vine-tsc@299

@vue-vine/vite-plugin

npm i https://pkg.pr.new/vue-vine/vue-vine/@vue-vine/vite-plugin@299

vue-vine

npm i https://pkg.pr.new/vue-vine/vue-vine@299

commit: eea385a

@coderabbitai coderabbitai bot mentioned this pull request Aug 12, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unocss not working in v1.6.5
1 participant
@ShenQingchuan