packages/eslint-plugin/src/rules/format/format-html-self-closing.ts (4)

154-165: Prefer range-based fixes to avoid type casts and fragile string replacement

Current approach forces casting to TSESTree.Node and uses string replace on the entire startTag, which can inadvertently replace a '>' inside an attribute value. You can avoid both by using range-based fixes for the last '>' in the start tag.

Apply this diff:

-              const startTag = node.startTag as any as (TSESTree.Node | undefined)
-              const endTag = node.endTag as any as (TSESTree.Node | undefined)
+              const startTag = node.startTag
+              const endTag = node.endTag
               if (!startTag || !endTag) {
                 return []
               }
 
-              return [
-                // Replace '>' of startTag with '/>'
-                fixer.replaceText(startTag, context.sourceCode.getText(startTag).replace('>', '/>')),
-                // Remove the text from the end of startTag to the end of endTag
-                fixer.removeRange([startTag.range[1], endTag.range[1]]),
-              ]
+              // Replace the last '>' of the start tag with '/>'
+              const gt = startTag.range[1] - 1
+              return [
+                fixer.replaceTextRange([gt, gt + 1], '/>'),
+                // Remove the text from the end of startTag to the end of endTag
+                fixer.removeRange([startTag.range[1], endTag.range[1]]),
+              ]

---

131-133: Tighten types: avoid optional chaining for options

createEslintRule supplies defaultOptions, so context.options[0] should always exist. Dropping ?. improves type safety and avoids unnecessary Option | undefined union types.

-    const options = context.options?.[0]
+    const options = context.options[0]

---

24-34: Fix minor typo in comment

Typo: “wil” → “will”.

- * These strings wil be displayed in error messages.
+ * These strings will be displayed in error messages.

---

153-166: Consider adding tests for malformed/missing endTag cases

Now that the fixer defensively no-ops when tags are missing, add RuleTester cases to assert:

• It reports but does not crash when endTag is missing.
• It produces no fixes (empty fix array) in that scenario.

I can draft the test cases if helpful.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled
• Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

Learnt from: ShenQingchuan
PR: vue-vine/vue-vine#283
File: packages/vscode-ext/package.json:105-110
Timestamp: 2025-06-17T14:54:18.385Z
Learning: The Vue Vine VSCode extension uses tsdown as a bundler that statically analyzes and includes all imported dependencies in the final bundle, regardless of whether they are listed in dependencies or devDependencies in packages/vscode-ext/package.json. Runtime dependencies can safely be placed in devDependencies since they will be bundled into the extension output.