releasing: next-patch - v1.7.6 #307
Conversation
✅ Deploy Preview for vue-vine ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Rate limit exceeded@ShenQingchuan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 57 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (6)
WalkthroughAdds export-unwrapping and TypeScript enum handling to top-level binding analysis in the compiler. Adjusts binding kinds for const/let/var. Ensures Vine component function declarations are skipped after identification. Expands tests to verify bindings and that separated/inline modes include top-level declarations in setup returns. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant TS as TypeScript AST
participant Analyzer as Analyzer (analyze.ts)
participant Binder as Binding Table
participant Transformer as Transform (setup returns)
TS->>Analyzer: Provide top-level statements
loop For each top-level stmt
Analyzer->>Analyzer: Unwrap export declarations
alt TSEnumDeclaration
Analyzer->>Binder: Record name → literal-const
else VariableDeclaration
alt const
Analyzer->>Binder: name → literal-const
else let/var
Analyzer->>Binder: name → setup-let
end
else Function/Class/Other
Analyzer->>Binder: Record binding kind as per rules
note right of Analyzer: If Vine component fn detected, continue
end
end
Analyzer-->>Transformer: Binding table
Transformer->>Transformer: Generate setup returns (inline & separated)
Transformer-->>Caller: Code with top-level bindings exposed
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Assessment against linked issues
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
282539f to
85b20b5
Compare
@vue-vine/compiler
create-vue-vine
@vue-vine/eslint-config
@vue-vine/eslint-parser
@vue-vine/eslint-plugin
@vue-vine/language-server
@vue-vine/language-service
@vue-vine/nuxt
vue-vine-tsc
@vue-vine/vite-plugin
vue-vine
commit: |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
packages/compiler/tests/__snapshots__/transform.spec.ts.snapis excluded by!**/*.snap
📒 Files selected for processing (3)
packages/compiler/src/analyze.ts(5 hunks)packages/compiler/tests/analyze.spec.ts(2 hunks)packages/compiler/tests/transform.spec.ts(3 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-07-20T18:38:22.094Z
Learnt from: CR
PR: vue-vine/vue-vine#0
File: .cursor/rules/vue-vine-repo-rules.mdc:0-0
Timestamp: 2025-07-20T18:38:22.094Z
Learning: Applies to **/*.vine.ts : 在 `.vine.ts` 文件中，所有函数只要满足条件：“返回值是一个 tagged template string 且标签名必须是 `vine` 的字符串”，都将被视为一个组件函数
Applied to files:
packages/compiler/src/analyze.tspackages/compiler/tests/transform.spec.ts
📚 Learning: 2025-07-20T18:38:22.094Z
Learnt from: CR
PR: vue-vine/vue-vine#0
File: .cursor/rules/vue-vine-repo-rules.mdc:0-0
Timestamp: 2025-07-20T18:38:22.094Z
Learning: Applies to **/*.vine.ts : Vine 仅会处理文件名后缀为 `.vine.ts` 的文件
Applied to files:
packages/compiler/tests/transform.spec.ts
🧬 Code Graph Analysis (3)
packages/compiler/src/analyze.ts (2)
packages/compiler/src/constants.ts (1)
VineBindingTypes(97-138)packages/compiler/src/babel-helpers/ast.ts (2)
isVineCompFnDecl(50-97)getFunctionPickedInfos(264-309)
packages/compiler/tests/analyze.spec.ts (2)
packages/compiler/tests/test-utils.ts (1)
createMockTransformCtx(4-26)packages/compiler/src/index.ts (1)
compileVineTypeScriptFile(143-173)
packages/compiler/tests/transform.spec.ts (3)
packages/compiler/src/index.ts (2)
VineCompilerOptions(42-42)compileVineTypeScriptFile(143-173)packages/compiler/src/types.ts (1)
VineCompilerOptions(81-102)packages/compiler/tests/test-utils.ts (1)
createMockTransformCtx(4-26)
🔇 Additional comments (11)
packages/compiler/src/analyze.ts (6)
49-49: LGTM!The addition of
isExportNamedDeclarationandisTSEnumDeclarationimports aligns well with the PR's objective to handle top-level exports and TypeScript enums properly.Also applies to: 63-63
334-337: Good simplification of enum handling.The change to treat TypeScript enums as
LITERAL_CONSTdirectly removes the complex per-member initialization logic. This makes the code cleaner and aligns with the deterministic handling goal.
783-791: Excellent implementation for handling Vine component function declarations.The logic correctly:
- Identifies Vine component function declarations
- Adds them to bindings as
SETUP_CONST- Uses
continueto skip further processing for these declarationsThis ensures proper separation between component functions and regular top-level declarations.
793-799: Proper unwrapping of export declarations.The code correctly unwraps
ExportDefaultDeclarationandExportNamedDeclarationto access the underlying declaration, allowing proper analysis of exported entities.
801-809: Accurate binding type assignment for variable declarations.The logic correctly distinguishes between
constdeclarations (yieldingLITERAL_CONST) and other kinds (yieldingSETUP_LET), which aligns with the PR objectives to handle top-level declarations properly.
818-820: Correct handling of TypeScript enums.The addition of explicit handling for
TSEnumDeclarationat the top level asLITERAL_CONSTis consistent with the enum handling inanalyzeVineFnBodyStmtForBindings.packages/compiler/tests/analyze.spec.ts (2)
399-399: LGTM! Test correctly validates enum binding.The test expectation properly validates that
MyOutsideEnumis treated asliteral-const, which aligns with the enum handling changes in the analyzer.
619-669: Comprehensive test coverage for top-level declarations.The new test suite thoroughly validates the binding analysis for various top-level declarations including:
- Exported arrow and plain functions
- Classes and enums
- Const and let variables
The assertions correctly verify that each entity receives the appropriate binding type.
packages/compiler/tests/transform.spec.ts (3)
1-1: LGTM! Necessary import for test helper.The addition of the
VineCompilerOptionstype import is required for the new test helper function's type annotations.
120-136: Well-structured test helper function.The
getFormatedCodegenResulthelper effectively encapsulates the common test setup and formatting logic, improving code reusability across tests.
475-516: Excellent test coverage for top-level declaration bindings.The test comprehensively validates that top-level declarations are correctly included in the setup returns for both inline and separated template modes. This ensures the fix for issue #306 works correctly across different compilation modes.
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/compiler/src/analyze.ts (1)
810-817: Guard function/class bindings to respect local shadowing.Same precedence concern as variables: use
??=to avoid overriding component-local identifiers.Apply this diff:
- vineCompFnCtx.bindings[declStmt.id.name] = VineBindingTypes.LITERAL_CONST + vineCompFnCtx.bindings[declStmt.id.name] ??= VineBindingTypes.LITERAL_CONST
🧹 Nitpick comments (3)
packages/compiler/tests/analyze.spec.ts (1)
618-669: Solid coverage for top-level declarations in bindings.This test exercises exported and non-exported top-level decls and checks the expected binding kinds, including enums and
let. One nit: the template referencesMyClass.getFoo()andmyInstance.num()but the class here doesn’t define them. It doesn’t affect analysis, but adding stubs would reduce confusion for future readers.Would you like me to send a patch to add those methods here (as you did in transform tests) for consistency?
packages/compiler/tests/transform.spec.ts (2)
120-137: Avoid spreading possibly-undefined options; consider typo fix.
- If
optionsis ever omitted,{ ...options }will throw at runtime. Preferoptions ?? {}.- Optional nit: rename
getFormatedCodegenResulttogetFormattedCodegenResult.Apply this diff to harden the helper:
-async function getFormatedCodegenResult( +async function getFormattedCodegenResult( specContent: string, options?: VineCompilerOptions, ) { - const { mockCompilerCtx, mockCompilerHooks } = createMockTransformCtx({ - ...options, - }) + const { mockCompilerCtx, mockCompilerHooks } = createMockTransformCtx(options ?? {}) compileVineTypeScriptFile(specContent, 'testTransformSeparatedResult', { compilerHooks: mockCompilerHooks }) expect(mockCompilerCtx.vineCompileErrors.length).toBe(0) const fileCtx = mockCompilerCtx.fileCtxMap.get('testTransformSeparatedResult') const transformed = fileCtx?.fileMagicCode.toString() ?? '' const formated = await format( transformed, { parser: 'babel-ts' }, ) return formated }And update the two call sites below accordingly.
475-516: Great end-to-end validation for inline vs separated modes.This test ensures top-level decls flow into setup returns consistently across both modes and that the generated outputs remain stable. After renaming the helper (if applied), update the invocations.
Apply this diff if you accept the helper rename:
- const inlineModeResult = await getFormatedCodegenResult(specContent, { + const inlineModeResult = await getFormattedCodegenResult(specContent, { inlineTemplate: true, }) - const separatedModeResult = await getFormatedCodegenResult(specContent, { + const separatedModeResult = await getFormattedCodegenResult(specContent, { inlineTemplate: false, })
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
packages/compiler/tests/__snapshots__/transform.spec.ts.snapis excluded by!**/*.snap
📒 Files selected for processing (3)
packages/compiler/src/analyze.ts(5 hunks)packages/compiler/tests/analyze.spec.ts(2 hunks)packages/compiler/tests/transform.spec.ts(3 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-07-20T18:38:22.094Z
Learnt from: CR
PR: vue-vine/vue-vine#0
File: .cursor/rules/vue-vine-repo-rules.mdc:0-0
Timestamp: 2025-07-20T18:38:22.094Z
Learning: Applies to **/*.vine.ts : Vine 仅会处理文件名后缀为 `.vine.ts` 的文件
Applied to files:
packages/compiler/tests/transform.spec.ts
📚 Learning: 2025-07-20T18:38:22.094Z
Learnt from: CR
PR: vue-vine/vue-vine#0
File: .cursor/rules/vue-vine-repo-rules.mdc:0-0
Timestamp: 2025-07-20T18:38:22.094Z
Learning: Applies to **/*.vine.ts : 在 `.vine.ts` 文件中，所有函数只要满足条件：“返回值是一个 tagged template string 且标签名必须是 `vine` 的字符串”，都将被视为一个组件函数
Applied to files:
packages/compiler/tests/transform.spec.tspackages/compiler/src/analyze.ts
🧬 Code Graph Analysis (3)
packages/compiler/tests/transform.spec.ts (3)
packages/compiler/src/index.ts (2)
VineCompilerOptions(42-42)compileVineTypeScriptFile(143-173)packages/compiler/src/types.ts (1)
VineCompilerOptions(81-102)packages/compiler/tests/test-utils.ts (1)
createMockTransformCtx(4-26)
packages/compiler/src/analyze.ts (2)
packages/compiler/src/constants.ts (1)
VineBindingTypes(97-138)packages/compiler/src/babel-helpers/ast.ts (2)
isVineCompFnDecl(50-97)getFunctionPickedInfos(264-309)
packages/compiler/tests/analyze.spec.ts (2)
packages/compiler/tests/test-utils.ts (1)
createMockTransformCtx(4-26)packages/compiler/src/index.ts (1)
compileVineTypeScriptFile(143-173)
🔇 Additional comments (7)
packages/compiler/src/analyze.ts (5)
49-49: Good addition: importisExportNamedDeclaration.Needed for the new export-unwrapping logic below.
63-63: Good addition: importisTSEnumDeclaration.Enables explicit handling of TS enums in binding analysis.
334-337: Enum inside function body treated as literal-const is reasonable.Marking
TSEnumDeclarationasLITERAL_CONSTaligns with non-reactive, non-ref semantics used in templates.
784-791: Usinglet+continueavoids reprocessing Vine component decls.This is an effective way to short-circuit after component identification and prevents double classification.
793-800: Export unwrapping is correct and necessary.Unwrapping
export defaultandexport nameddeclarations ensures the inner declarations are analyzed uniformly. This fixes the exported-top-level omission described in the issue.packages/compiler/tests/analyze.spec.ts (1)
399-400: Snapshot update to includeMyOutsideEnumlooks correct.Enum classification as
literal-constmatches new analysis behavior.packages/compiler/tests/transform.spec.ts (1)
1-1: Type-only import is fine.It keeps runtime bundle clean while documenting the helper’s options shape.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
v2.0.0-alpha11(latest version for now) and using Rolldown to build our docs, improving CI speed.Summary by CodeRabbit
New Features
Tests