Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(runtime-dom): avoid unset option's value #10416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 28, 2024
Merged

fix(runtime-dom): avoid unset option's value #10416

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1661fa8
fix(runtime-dom): avoid unset option's value
Doctor-wu Feb 27, 2024
b8aff0b
test: add test case
Doctor-wu Feb 27, 2024
03ed4a9
fix: fix test case
Doctor-wu Feb 27, 2024
c799b00
feat: add comment
Doctor-wu Feb 28, 2024
88a5af7
Update props.ts
yyx990803 Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/runtime-dom/__tests__/patchProps.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,18 @@ describe('runtime-dom: props patching', () => {
expect(el.value).toBe('baz')
})

test('init empty value for option', () => {
const root = document.createElement('div')
render(
h('select', { value: 'foo' }, [h('option', { value: '' }, 'foo')]),
root,
)
const select = root.children[0] as HTMLSelectElement
const option = select.children[0] as HTMLOptionElement
expect(select.value).toBe('')
expect(option.value).toBe('')
})

// #8780
test('embedded tag with width and height', () => {
// Width and height of some embedded element such as img、video、source、canvas
Expand Down
8 changes: 6 additions & 2 deletions packages/runtime-dom/src/modules/props.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,17 @@ export function patchDOMProp(
// custom elements may use _value internally
!tag.includes('-')
) {
const mounted = '_value' in el
// store value as _value as well since
// non-string values will be stringified.
el._value = value
// #4956: <option> value will fallback to its text content so we need to
// compare against its attribute value instead.
const oldValue =
tag === 'OPTION' ? el.getAttribute('value') || '' : el.value
let oldValue = el.value
if (tag === 'OPTION') {
const attrValue = el.getAttribute('value')
oldValue = mounted ? attrValue || '' : attrValue
}
const newValue = value == null ? '' : value
if (oldValue !== newValue) {
el.value = newValue
Expand Down