Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(reactivity): chained computeds lost reactivity #11170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(reactivity): chained computeds lost reactivity #11170

wants to merge 1 commit into from

Conversation

@wanghanzhen
Copy link

@wanghanzhen wanghanzhen commented Jun 18, 2024

When getting dirty and _dirtyLevel === DirtyLevels.MaybeDirty_ComputedSideEffect_Origin, it's supposed to execute resetTracking before return true. Otherwise, computed after that cannot be tracked and ends up losing reactivity.

Fix #11169

@Doctor-wu
Copy link
Member

Doctor-wu commented Jun 18, 2024

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Jun 18, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools ✅ success ✅ success
nuxt ✅ success ✅ success
pinia ✅ success ✅ success
primevue ✅ success ✅ success
quasar ✅ success ✅ success
radix-vue ✅ success ✅ success
router ✅ success ✅ success
test-utils ✅ success ✅ success
vant ✅ success ✅ success
vite-plugin-vue ✅ success ✅ success
vitepress ✅ success ✅ success
vue-i18n ✅ success ✅ success
vue-macros ✅ success ✅ success
vuetify ✅ success ✅ success
vueuse ✅ success ✅ success
vue-simple-compiler ✅ success ✅ success

@wanghanzhen
Copy link
Author

wanghanzhen commented Jun 19, 2024 •
edited
Loading

Hold on, just found a Maximum recursion error in my project after adding resetTracking😨
At present, the minimum reproduction has not been found yet.

@Doctor-wu
Copy link
Member

Doctor-wu commented Jun 19, 2024

@wanghanzhen could you try to provide reproduce, I think it's necessary to add resetTracking here to align behaviour with others dirty level

@wanghanzhen
Copy link
Author

wanghanzhen commented Jun 20, 2024

@Doctor-wu Finally got the reproduction. Here is the link:
https://play.vuejs.org/#eNp9UstOwzAQ/JWVL7SiSoFyoaSVAIEEB6iAoyWUJpuSktiWH6Eoyr+zdvpCoj0l2ZnZnd1Mw26UimqHbMxik+pCWTBonZpyUVRKagsNpLJSzmI2AI05tJBrWcEJiU644CKVwljIpYSJx3tn/etdeZ5oKm8a9Hp9mEyh4QK8IKqT0iGcTuCcJEBq67TYIVRs95ulB1qtdQ1kYz9w3bbdyeNhtxotFVusVJlYpHeAOCvqaUMbRhm0bTz0n4fr8XBPzAbMGvKVF4toaaSgAwYznHmLRYn6RdmCfHM27mx6LClL+f0UalY7HGzq6SemX//Ul2bla5zNNBrUNXK2xWyiF2g7+P7tGVf0vgUrmbmS2EfAVzSydN5jR7t1IiPbe7zg9jHEoBCLd3O/sijMZilv1DPbwOeMAnF3ZPWd3VE0Cjr6P3TFGWo6H92QLriN3OGgqUC/k07Yv4HDVdDmTqR++Jr4kKRW6p+eSCrsd2a6PnK+JP3anUfHoVnghYV8fvxzb+CBwFIrn7WQiY+a6DSelhlFl9HFFWt/ASbpIVA=

please confirm added resetTracking in source of devtools.
image

@Doctor-wu
Copy link
Member

Doctor-wu commented Jun 20, 2024 •
edited
Loading

@Doctor-wu Finally got the reproduction. Here is the link: play.vuejs.org/#eNp9UstOwzAQ/JWVL7SiSoFyoaSVAIEEB6iAoyWUJpuSktiWH6Eoyr+zdvpCoj0l2ZnZnd1Mw26UimqHbMxik+pCWTBonZpyUVRKagsNpLJSzmI2AI05tJBrWcEJiU644CKVwljIpYSJx3tn/etdeZ5oKm8a9Hp9mEyh4QK8IKqT0iGcTuCcJEBq67TYIVRs95ulB1qtdQ1kYz9w3bbdyeNhtxotFVusVJlYpHeAOCvqaUMbRhm0bTz0n4fr8XBPzAbMGvKVF4toaaSgAwYznHmLRYn6RdmCfHM27mx6LClL+f0UalY7HGzq6SemX//Ul2bla5zNNBrUNXK2xWyiF2g7+P7tGVf0vgUrmbmS2EfAVzSydN5jR7t1IiPbe7zg9jHEoBCLd3O/sijMZilv1DPbwOeMAnF3ZPWd3VE0Cjr6P3TFGWo6H92QLriN3OGgqUC/k07Yv4HDVdDmTqR++Jr4kKRW6p+eSCrsd2a6PnK+JP3anUfHoVnghYV8fvxzb+CBwFIrn7WQiY+a6DSelhlFl9HFFWt/ASbpIVA=

please confirm added resetTracking in source of devtools. image

@wanghanzhen It's occurred an error in 3.4.28 as well, could you commit a specific issue for this? I'll try to fix this and #11169 I'll commit the issue

@Doctor-wu Doctor-wu mentioned this pull request Jun 20, 2024
Closed
@Doctor-wu
Copy link
Member

Doctor-wu commented Jun 20, 2024 •
edited
Loading

@wanghanzhen Submitted #11183 for fixing both #11169 and #11181, reused your test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Doctor-wu Doctor-wu Doctor-wu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chain computed lost reactivity when computed effect happens

3 participants

@wanghanzhen @Doctor-wu @vue-bot