Codestin Search App

edison1105 · 2026-01-26T01:41:56Z

close #14357

Summary by CodeRabbit

Tests
- Added coverage verifying reactive updates continue to trigger correctly when scopes are stored on reactive objects and are started/stopped.
New Features
- Effect scope now exposes a skip flag to support improved handling of scoped reactive behavior.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

… conversion

coderabbitai · 2026-01-26T01:42:16Z

📝 Walkthrough

Walkthrough

The changes add a new test case validating effect scope lifecycle behavior when scopes are stored on reactive objects, and introduce a public __v_skip flag to the EffectScope class.

Changes

Cohort / File(s)	Summary
Test Suite Enhancement `packages/reactivity/__tests__/effectScope.spec.ts`	New test "should still trigger updates after stopping scope stored in reactive object" verifying staged updates and effectScope start/stop behavior when a scope is stored on a reactive object.
EffectScope Public Surface `packages/reactivity/src/effectScope.ts`	Adds public readonly field `__v_skip = true` to the `EffectScope` class (new public property).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

ready to merge, scope: reactivity, :hammer: p3-minor-bug

Suggested reviewers

jh-leong

Poem

🐰 I hopped into scopes both near and deep,
Watched effects that wake and those that sleep,
With a tiny flag — __v_skip in view —
The renders danced, stopped, and started anew. ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding a __v_skip flag to EffectScope to prevent reactive conversion, which directly addresses the issue of render updates stopping after effectScope.stop().
Linked Issues check	✅ Passed	The PR adds __v_skip flag to EffectScope and includes a test case validating that scope stored in reactive objects can still trigger updates after stopping, directly addressing issue `#14357`'s requirement to fix render updates after scope.stop().
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing the EffectScope reactive conversion issue: the __v_skip flag addition and the test case validating the fix remain within the scope of issue `#14357`.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-01-26T01:42:55Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	103 kB (+17 B)	39.1 kB (+3 B)	35.2 kB (+25 B)
vue.global.prod.js	162 kB (+17 B)	59.1 kB (+2 B)	52.6 kB (+52 B)

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	47 kB (+17 B)	18.4 kB (+3 B)	16.8 kB (-2 B)
createApp	55.2 kB (+17 B)	21.4 kB (+3 B)	19.6 kB (+1 B)
createSSRApp	59.4 kB (+17 B)	23.2 kB (+3 B)	21.1 kB (+2 B)
defineCustomElement	60.8 kB (+17 B)	23.2 kB (+3 B)	21.1 kB (+6 B)
overall	69.5 kB (+17 B)	26.7 kB (+3 B)	24.3 kB (+11 B)

pkg-pr-new · 2026-01-26T01:43:08Z

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14359

npm i https://pkg.pr.new/@vue/compiler-core@14359

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14359

npm i https://pkg.pr.new/@vue/compiler-dom@14359

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14359

npm i https://pkg.pr.new/@vue/compiler-sfc@14359

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14359

npm i https://pkg.pr.new/@vue/compiler-ssr@14359

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14359

npm i https://pkg.pr.new/@vue/reactivity@14359

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14359

npm i https://pkg.pr.new/@vue/runtime-core@14359

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14359

npm i https://pkg.pr.new/@vue/runtime-dom@14359

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14359

npm i https://pkg.pr.new/@vue/server-renderer@14359

yarn add https://pkg.pr.new/@vue/[email protected]

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14359

npm i https://pkg.pr.new/@vue/shared@14359

yarn add https://pkg.pr.new/@vue/[email protected]

vue

pnpm add https://pkg.pr.new/vue@14359

npm i https://pkg.pr.new/vue@14359

yarn add https://pkg.pr.new/[email protected]

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14359

npm i https://pkg.pr.new/@vue/compat@14359

yarn add https://pkg.pr.new/@vue/[email protected]

commit: a6e8ce6

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@packages/reactivity/__tests__/effectScope.spec.ts`:
- Around line 383-385: Remove the debug logging from the test by deleting the
console.log call inside the watch callback (the line that logs '-- rs', values)
in the test using watch([() => status.stage], ...); if the output was intended
for assertion, replace it with an appropriate expect assertion against values or
a spy, otherwise simply remove the console.log to avoid noisy test output.

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

edison1105 · 2026-01-27T00:42:42Z

/ecosystem-ci run

vue-bot · 2026-01-27T00:49:15Z

📝 Ran ecosystem CI: Open

suite	result	latest scheduled
pinia	✅ success	✅ success
test-utils	✅ success	✅ success
nuxt	✅ success	✅ success
primevue	✅ success	✅ success
vuetify	✅ success	✅ success
vite-plugin-vue	✅ success	✅ success
language-tools	✅ success	✅ success
vant	✅ success	❌ failure
vue-macros	✅ success	✅ success
quasar	✅ success	✅ success
radix-vue	✅ success	✅ success
vitepress	✅ success	✅ success
vueuse	✅ success	✅ success
vue-i18n	✅ success	✅ success
router	❌ failure	❌ failure
vue-simple-compiler	✅ success	✅ success

fix(reactivity): add __v_skip flag to EffectScope to prevent reactive…

0c8de9c

… conversion

coderabbitai Bot reviewed Jan 26, 2026

View reviewed changes

Comment thread packages/reactivity/__tests__/effectScope.spec.ts Outdated

Update packages/reactivity/__tests__/effectScope.spec.ts

a6e8ce6

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

edison1105 added scope: reactivity 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. labels Jan 26, 2026

edison1105 merged commit 48b7552 into main Feb 9, 2026
20 of 21 checks passed

edison1105 deleted the edison/fix/14357 branch February 9, 2026 07:56

claude Bot mentioned this pull request Feb 12, 2026

chore(deps): update dependency vue to v3.5.28 - autoclosed cbcoutinho/nextcloud-mcp-server#554

Closed

1 task

coderabbitai Bot mentioned this pull request Mar 13, 2026

fix(server-renderer): cleanup component effect scopes after SSR render #14548

Merged

coderabbitai Bot mentioned this pull request Apr 3, 2026

fix(ssr): avoid triggering onScopeDispose during SSR cleanup #14673

Closed

coderabbitai Bot mentioned this pull request Apr 17, 2026

fix(reactivity): unlink effect scopes on out-of-order off #14734

Merged

coderabbitai Bot mentioned this pull request May 4, 2026

fix(reactivity): prevent orphan effect when created in a stopped scope #14778

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(reactivity): add __v_skip flag to EffectScope to prevent reactive conversion#14359

fix(reactivity): add __v_skip flag to EffectScope to prevent reactive conversion#14359
edison1105 merged 2 commits into
mainfrom
edison/fix/14357

edison1105 commented Jan 26, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jan 26, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested labels

Suggested reviewers

Poem

Uh oh!

github-actions Bot commented Jan 26, 2026

Uh oh!

pkg-pr-new Bot commented Jan 26, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

edison1105 commented Jan 27, 2026

Uh oh!

vue-bot commented Jan 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

edison1105 commented Jan 26, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

Suggested reviewers

Poem

Uh oh!

github-actions Bot commented Jan 26, 2026

Size Report

Bundles

Usages

Uh oh!

pkg-pr-new Bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

edison1105 commented Jan 27, 2026

Uh oh!

vue-bot commented Jan 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

edison1105 commented Jan 26, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jan 26, 2026 •

edited

Loading

pkg-pr-new Bot commented Jan 26, 2026 •

edited

Loading