Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(runtime-dom): fix an update error when the style changed from str… #5362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(runtime-dom): fix an update error when the style changed from str… #5362

wants to merge 1 commit into from

Conversation

hg3w
Copy link

@hg3w hg3w commented Feb 5, 2022

When I changed the style from string to object, the properties of the original string were not removed:

<div :style="flag ? `color: red;` : { backgroundColor: 'green' }">

<!-- flag changes from true to false and is rendered as: -->
<div style="color: red; background-color: green;">

After this PR, the rendering style displays normally:

<div style="background-color: green;">

@netlify
Copy link

netlify bot commented Feb 5, 2022 •
edited
Loading

✔️ Deploy Preview for vuejs-coverage ready!

🔨 Explore the source changes: ea98cfe

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/61fe8ba4b489e70008fb0ba2

😎 Browse the preview: https://deploy-preview-5362--vuejs-coverage.netlify.app

@netlify
Copy link

netlify bot commented Feb 5, 2022 •
edited
Loading

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: ea98cfe

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/61fe8ba4c7e8b20007350341

😎 Browse the preview: https://deploy-preview-5362--vue-next-template-explorer.netlify.app

@netlify
Copy link

netlify bot commented Feb 5, 2022 •
edited
Loading

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: ea98cfe

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/61fe8ba4ec11e20008c45bd0

😎 Browse the preview: https://deploy-preview-5362--vue-sfc-playground.netlify.app/

@haoqunjiang
Copy link
Member

Thanks for the PR! Sorry that we didn't notice this one earlier.
Now we've merged #10373 and this issue has been fixed since v3.4.20.

@haoqunjiang haoqunjiang closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Issue / PR Management
Status: Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hg3w @haoqunjiang