Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(watch): replace instance unmounted with scope inactive #9949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(watch): replace instance unmounted with scope inactive #9949

wants to merge 1 commit into from

Conversation

yangmingshan
Copy link
Contributor

Ref: #7330 (comment)

This is solution 2, low risk.
Solution 1: #9948

@yangmingshan yangmingshan mentioned this pull request Dec 30, 2023
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 30, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.4 kB (-47 B) 34 kB (-12 B) 30.7 kB (+11 B)
vue.global.prod.js 146 kB (-47 B) 53.3 kB (-14 B) 47.7 kB (+47 B)

Usages

Name Size Gzip Brotli
createApp 49.8 kB (-47 B) 19.5 kB (-20 B) 17.8 kB (-22 B)
createSSRApp 53.1 kB (-47 B) 20.8 kB (-22 B) 19 kB (-24 B)
defineCustomElement 52 kB (-47 B) 20.2 kB (-21 B) 18.5 kB (-30 B)
overall 63.3 kB (-47 B) 24.4 kB (-23 B) 22.2 kB (-66 B)

@pikax
Copy link
Member

pikax commented Jan 2, 2024

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Jan 2, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools ❌ failure ❌ failure
nuxt ✅ success ❌ failure
pinia ✅ success ✅ success
quasar ✅ success ✅ success
router ✅ success ✅ success
test-utils ✅ success ✅ success
vant ✅ success ✅ success
vite-plugin-vue ✅ success ✅ success
vitepress ✅ success ✅ success
vue-i18n ✅ success ✅ success
vue-macros ❌ failure ❌ failure
vuetify ❌ failure ❌ failure
vueuse ❌ failure ❌ failure
vue-simple-compiler ✅ success ✅ success

@yyx990803 yyx990803 closed this Jan 3, 2024
@yangmingshan yangmingshan deleted the watchEffect2 branch January 3, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yangmingshan @pikax @vue-bot @yyx990803