-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Note that verbatimModuleSyntax meets the suggested criteria for isolatedModules
#2592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atedModules` See also vuejs/create-vue#401
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NataliaTepluhina
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmulholland thank you for the contribution!
undergroundwires
added a commit
to undergroundwires/privacy.sexy
that referenced
this pull request
Feb 24, 2024
This commit bumps the TypeScript version to latest 5.3. It also introduces `verbatimModuleSyntax` configuration, a feature of TypeScript 5. This enables the restriction for import statements that `import type` must be used if the imported thing is used as a type only (and not used as a value). Such imports will get fully erased when TypeScript compiles the sources to JavaScript. Also it can help tools like bundlers to determine whether an import is needed at runtime or not. - Replace deprecated "import assertions" syntax with "import attributes". ESLint supports it (typescript-eslint/typescript-eslint#7719). - Enable `verbatimModuleSyntax` improved in 5.3, refactor the code to use type-only imports. Its usage is endorsed by offical Vue guide (vuejs/docs#2592).
undergroundwires
added a commit
to undergroundwires/privacy.sexy
that referenced
this pull request
Feb 27, 2024
This commit bumps the TypeScript version to latest 5.3. It also introduces `verbatimModuleSyntax` configuration, a feature of TypeScript 5, endorsed by offical Vue guide (vuejs/docs#2592). This enables the restriction for import statements that `import type` must be used if the imported thing is used as a type only (and not used as a value). Such imports will get fully erased when TypeScript compiles the sources to JavaScript. Also it can help tools like bundlers to determine whether an import is needed at runtime or not. - Replace deprecated "import assertions" syntax with "import attributes". ESLint supports it (typescript-eslint/typescript-eslint#7719).
undergroundwires
added a commit
to undergroundwires/privacy.sexy
that referenced
this pull request
Feb 27, 2024
This commit upgrades TypeScript to the latest version 5.3 and introduces `verbatimModuleSyntax` in line with the official Vue guide recommendatinos (vuejs/docs#2592). By enforcing `import type` for type-only imports, this commit improves code clarity and supports tooling optimization, ensuring imports are only bundled when necessary for runtime. Changes: - Bump TypeScript to 5.3.3 across the project. - Adjust import statements to utilize `import type` where applicable, promoting cleaner and more efficient code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also vuejs/create-vue#401