Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Note that verbatimModuleSyntax meets the suggested criteria for isolatedModules #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

bmulholland
Copy link
Contributor

Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit cdaddbe
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/657070795006840008edb5c9
😎 Deploy Preview https://deploy-preview-2592--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmulholland thank you for the contribution!

@NataliaTepluhina NataliaTepluhina merged commit 32c0a6a into vuejs:main Dec 6, 2023
undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this pull request Feb 24, 2024
This commit bumps the TypeScript version to latest 5.3.
It also introduces `verbatimModuleSyntax` configuration, a feature of
TypeScript 5. This enables the restriction for import statements that
`import type` must be used if the imported thing is used as a type only
(and not used as a value). Such imports will get fully erased when
TypeScript compiles the sources to JavaScript. Also it can help tools
like bundlers to determine whether an import is needed at runtime or not.

- Replace deprecated "import assertions" syntax with "import
  attributes".
  ESLint supports it (typescript-eslint/typescript-eslint#7719).
- Enable `verbatimModuleSyntax` improved in 5.3, refactor the code to
  use type-only imports.
  Its usage is endorsed by offical Vue guide (vuejs/docs#2592).
undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this pull request Feb 27, 2024
This commit bumps the TypeScript version to latest 5.3.
It also introduces `verbatimModuleSyntax` configuration, a feature of
TypeScript 5, endorsed by offical Vue guide (vuejs/docs#2592).

This enables the restriction for import statements that
`import type` must be used if the imported thing is used as a type only
(and not used as a value). Such imports will get fully erased when
TypeScript compiles the sources to JavaScript. Also it can help tools
like bundlers to determine whether an import is needed at runtime or not.

- Replace deprecated "import assertions" syntax with "import
  attributes".
  ESLint supports it (typescript-eslint/typescript-eslint#7719).
undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this pull request Feb 27, 2024
This commit upgrades TypeScript to the latest version 5.3 and introduces
`verbatimModuleSyntax` in line with the official Vue guide
recommendatinos (vuejs/docs#2592).

By enforcing `import type` for type-only imports, this commit improves
code clarity and supports tooling optimization, ensuring imports are
only bundled when necessary for runtime.

Changes:

- Bump TypeScript to 5.3.3 across the project.
- Adjust import statements to utilize `import type` where applicable,
  promoting cleaner and more efficient code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants