fix(block-lang): use consistent quotation marks in error messages #2805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d411539 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
FloEdelmann
approved these changes
Jul 18, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes quotation marks in error messages for the vue/block-lang ESLint rule to use single quotes consistently throughout. The changes address inconsistent usage of double quotes, single quotes, and backticks in error messages by converting all quotes to single quotes for better consistency.
- Standardized all quotation marks in error messages to use single quotes instead of mixed quote styles
- Updated test cases to reflect the new consistent error message format
- Added position information (endLine, endColumn) to test expectations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/rules/block-lang.js | Updated error message templates and helper function to use single quotes consistently |
| tests/lib/rules/block-lang.js | Updated test expectations to match new error message format and added missing position data |
| .changeset/strong-masks-fetch.md | Added changelog entry documenting the fix for inconsistent quotes |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-Up on #2804
While updating the tests, I noticed that the error messages use
",'and`for quoting/highlighting things.This PR changes this to only use
'.Does this qualify as
fix? Do I need to create an issue for this one?Blocked by #2804test(block-lang): make tests more strict #2804