Update: Add allowEmptyLines option to vue/multiline-html-element-content-newline rule
#759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntent-newline` rule Close #683
armano2
suggested changes
Jan 8, 2019
armano2
reviewed
Jan 8, 2019
armano2
reviewed
Jan 8, 2019
armano2
reviewed
Jan 8, 2019
armano2
reviewed
Jan 8, 2019
armano2
reviewed
Jan 8, 2019
armano2
reviewed
Jan 8, 2019
armano2
reviewed
Jan 8, 2019
armano2
reviewed
Jan 8, 2019
arrowEmptyLine option to vue/multiline-html-element-content-newline ruleallowEmptyLine option to vue/multiline-html-element-content-newline rule
|
@armano2 Thank you for pointing that out 😖 I fixed it. |
michalsnik
reviewed
Jan 9, 2019
| @@ -87,6 +88,8 @@ This rule enforces a line break before and after the contents of a multiline ele | |||
| default `true` | |||
| - `ignores` ... the configuration for element names to ignore line breaks style. | |||
| default `["pre", "textarea"]` | |||
| - `allowEmptyLine` ... if `true`, allow empty line. If disallow multiple empty lines, use [no-multiple-empty-lines] in combination. | |||
There was a problem hiding this comment.
Implementation-wise it looks like allowEmptyLines might be a bit more correct option 🤔
As for copy, what do you think about: "... if true, it allows empty lines around content. If you want to disallow multiple empty lines, use ..."?
Also, does the core no-multiple-empty-lines rule work with Vue template by default?
There was a problem hiding this comment.
Also, does the core no-multiple-empty-lines rule work with Vue template by default?
If no-multiple-empty-lines rule is enabled, no-multiple-empty-lines rule also checks in the Vue template.
|
@michalsnik Thank you for your review. |
allowEmptyLine option to vue/multiline-html-element-content-newline ruleallowEmptyLines option to vue/multiline-html-element-content-newline rule
michalsnik
approved these changes
Jan 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #683
This PR adds
allowEmptyLinesoption tovue/multiline-html-element-content-newlinerule.allowEmptyLines... iftrue, it allows empty lines around content. If you want to disallow multiple empty lines, use no-multiple-empty-lines in combination.default
false