revert: type support of slot children (#5137) #5514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vue-component-meta
vue-component-type-helpers
@vue/language-core
@vue/language-plugin-pug
@vue/language-server
@vue/language-service
vue-tsc
@vue/typescript-plugin
commit: |
|
Oh, very sad to see this. We already used it internally and were very happy that this was possible. Would it be possible to enable this feature under a flag of |
|
The current implementation may not be the same as the final solution, so we hope to avoid too much breaking changes caused by late modifications. Sorry for setting the false expectations. |
|
Why not enable it via an experimental flag? Users should expect bugs or breaking changes from an experimental feature. Something like: {
"vueCompilerOptions": {
"experimental": {
"strictSlotChildren" true
}
}
}I would rather have breaking changes with an experimental feature than having to wait for the feature to be fully released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion, we believe the implementation of this feature is not yet mature and cannot adequately address real-world scenarios. Therefore, we revert it for now and will continue to wait for progress on this rfc.