Thanks to visit codestin.com
Credit goes to github.com

Skip to content

sidebar uses native <details> for collapsible groups [#3804. also #3517] #3806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

sidebar uses native <details> for collapsible groups [#3804. also #3517] #3806

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c46746b
refactor(VPSidebarItem): use hasChildren
olets Apr 18, 2024
ce416c9
feat(VPSidebarItem): collapsible groups use 'details' [#3517, #3804, …
olets Apr 18, 2024
b1d8547
refactor(VPSidebarItem): no css nesting [pr #3806]
olets Apr 18, 2024
1420b95
refactor(VPSidebarItem): use :where() to reduce css weight [#3806]
olets May 15, 2024
91fd45c
chore(VPSidebarItem): correct hover style...
olets May 15, 2024
b96cc8f
chore(VPSidebarItem): fix regression: active collapsible has indicator
olets May 15, 2024
8dee268
chore(VPSidebarItem): revert 3805 work: active groups toggle open
olets May 16, 2024
16beebe
test(multi-sidebar): update for new markup
olets May 16, 2024
c3b1c77
fix(sidebar): revert dev qa content
olets May 27, 2024
d385f29
chore(VPSidebarItem): drop comment. no longer blocked by vue core bug
olets Jun 25, 2024
1eb17d1
chore(VPSidebarItem): whitespace
olets Jun 25, 2024
a08ea9f
chore(sidebar): drop console log
olets Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(VPSidebarItem): whitespace
  • Loading branch information
@olets
olets committed Jun 25, 2024
commit 1eb17d1a02c8cec3b514dc4e7901fc29c881b7cf
2 changes: 1 addition & 1 deletion src/client/theme-default/components/VPSidebarItem.vue
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.item:hover .caret and .item:hover .caret:hover styles should probably be merged and adjusted to .item summary:hover .caret { color: var(--vp-c-text-1) } (because currently item is whole element instead of just that title part)

Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ function onToggle(payload: ToggleEvent): void {
class="item"
>
<div class="indicator" />

<VPLink
v-if="item.link"
:tag="linkTag"
Expand Down