feat: internationalize code block copy button title #3854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nozomuikuta
commented
May 2, 2024
src/node/markdown/markdown.ts
Outdated
Comment on lines
188
to
191
| /** | ||
| * @default 'Copy Code' | ||
| */ | ||
| codeCopyButtonTitle?: string |
There was a problem hiding this comment.
Not sure, but should I put this in themeConfig for it to be aligned with other similar options in terms of developer experience?
There was a problem hiding this comment.
Ah no. themeConfig is theme dependent. People using other themes won't be able to use this option then. Moreover themeConfig is can be overloaded per locale. Markdown config currently doesn't support that 👀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3695
I tested it by linking the package to another project in my local with
file:protocol inpackage.json.Option name follows
lightModeSwitchTitle, etc.