Transform component's children to its default slot contents (fix #12232) #12417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
HTML tags written using some uppercase letters (i.e.
<H1>
or<Span>
) will stop rendering their children. This happens because those tags are considered components by themaybeComponent()
function, so after applying these changes their children will be considered the contents of its default slot. As native HTML tags doesn't have slots, they won't be rendered. This is explained in more detail in the attached video.The recommendation in this case is to write the standard HTML tags always in lowercase (in fact, in Vue 3 a "failed to resolve component" warning is displayed when an uppercase tag is used, even when it's still rendered).
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Vue_12232_error_and_fix.mp4
P.S.: I just realized I didn't show the fixed version working as expected in the video (I forgot to modify the input during the demo). If you find it necessary, I can upload another video showing it 🙂 thank you very much!