Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(compiler): scoped slot can't udate with with different slot content #12928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(compiler): scoped slot can't udate with with different slot content #12928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/compiler/codegen/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ function genScopedSlots(
// it's possible for the same component to be reused but with different
// compiled slot content. To avoid that, we generate a unique key based on
// the generated code of all the slot contents.
let needsKey = !!el.if
let needsKey = !!(el.if || el.elseif || el.else)

// OR when it is inside another scoped slot or v-for (the reactivity may be
// disconnected due to the intermediate scope variable)
Expand All @@ -449,7 +449,7 @@ function genScopedSlots(
needsForceUpdate = true
break
}
if (parent.if) {
if (parent.if || parent.elseif) {
needsKey = true
}
parent = parent.parent
Expand Down
69 changes: 63 additions & 6 deletions test/unit/features/component/component-scoped-slot.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1267,7 +1267,7 @@ describe('Component scoped slot', () => {
}).then(done)
})

// #9534
// #9534 #12922
it('should detect conditional reuse with different slot content', done => {
const Foo = {
template: `<div><slot :n="1" /></div>`
Expand All @@ -1276,25 +1276,44 @@ describe('Component scoped slot', () => {
const vm = new Vue({
components: { Foo },
data: {
ok: true
value: 'a'
},
template: `
<div>
<div v-if="ok">
<div v-if="value==='a'">
<foo v-slot="{ n }">{{ n }}</foo>
</div>
<div v-if="!ok">
<div v-else-if="value==='b'">
<foo v-slot="{ n }">{{ n + 1 }}</foo>
</div>
<div v-else-if="value==='c'">
<foo v-slot="{ n }">{{ n + 2 }}</foo>
</div>
<div v-else>
<foo v-slot="{ n }">{{ n + 3 }}</foo>
</div>
</div>
`
}).$mount()

expect(vm.$el.textContent.trim()).toBe(`1`)
vm.ok = false
vm.value = 'b'
waitForUpdate(() => {
expect(vm.$el.textContent.trim()).toBe(`2`)
}).then(done)
})
.then(() => {
vm.value = 'c'
})
.then(() => {
expect(vm.$el.textContent.trim()).toBe(`3`)
})
.then(() => {
vm.value = 'd'
})
.then(() => {
expect(vm.$el.textContent.trim()).toBe(`4`)
})
.then(done)
})

// #9644
Expand Down Expand Up @@ -1403,4 +1422,42 @@ describe('Component scoped slot', () => {
expect(parent.$el.textContent).toMatch(``)
}).then(done)
})
// #12223
it('should update when switching between components with slot', done => {
const Foo = {
template: `<div><slot :n="1" /></div>`
}

const vm = new Vue({
template: `<div>
<Foo v-if="value==='a'"><template v-slot="{ n }">{{ n }}</template></Foo>
<Foo v-else-if="value==='b'"><template v-slot="{ n }">{{ n + 1 }}</template></Foo>
<Foo v-else-if="value==='c'"><template v-slot="{ n }">{{ n + 2 }}</template></Foo>
<Foo v-else><template v-slot="{ n}">{{ n + 3 }}</template></Foo>
</div>`,
data: {
value: 'a'
},
components: { Foo }
}).$mount()

expect(vm.$el.textContent.trim()).toBe(`1`)
vm.value = 'b'
waitForUpdate(() => {
expect(vm.$el.textContent.trim()).toBe(`2`)
})
.then(() => {
vm.value = 'c'
})
.then(() => {
expect(vm.$el.textContent.trim()).toBe(`3`)
})
.then(() => {
vm.value = 'd'
})
.then(() => {
expect(vm.$el.textContent.trim()).toBe(`4`)
})
.then(done)
})
})