Add empty-to-undefined modifier to v-model #3566
Conversation
fix key modifiers detecting
fix comment
Update lang.js
fix: directive I/F consistency
- No need to merge props into the data object. they should just be defined as reactive properties on the vm instance. - They should not observe the value when set. They should already be reactive if needed.
'reprository' -> 'repository'
|
Decided that undefined makes more sense. The modifier is called |
|
this branch is now identical to base but tests still fail locally, completely different tests fail |
|
ok I'm done |
|
make sure to clear your npm cache, then run the tests again |
|
the CI runs every test on a brand new linux installation, right? |
|
CircleCI seems to cache dependencies, this hit me with a recent PR for vue-router: vuejs/vue-router#641 (comment) clear your local cache and re-run them, if that works locally, I guess Evan can reset circleCI'S cache ? |
|
Cleared my cache and reinstalled, which resulted in yet another random test failing on the base branch (v-for with transitions iirc). I guess I'll just rollback my rollback and wait for the CircleCI reset, giving up on my local copy. |
|
@yyx990803 Could you clear the CircleCI cache? |
Fixes #3541. Still haven't come up with a better name.