chore(dev-deps): migrate to rolldown-vite
#5138
Conversation
@vueuse/components
@vueuse/core
@vueuse/electron
@vueuse/firebase
@vueuse/integrations
@vueuse/math
@vueuse/metadata
@vueuse/nuxt
@vueuse/router
@vueuse/rxjs
@vueuse/shared
commit: |
rolldown-viterolldown-vite
|
We should update playgrounds, maybe updating nuxt also to v4. I guess adding vite with rolldown-vite at resolutions should be better. Maybe we should check first tests, vitest tests maybe broken using rolldown. |
|
We should update vitest to v4 or apply this patch to fix unit tests using node 24, will check if ported to v3: vitest-dev/vitest#8390 (comment) |
Oh, I did miss those, but we seem not to use
The errors in CI appear to be related to vitest: vitest-dev/vitest#8374. Upgrading to vitest v4 might resolve the issue. |
|
The |
Beware, there are some changes we need for browser tests and coverage, browser provider now must be imported from |
Where is the sh being used (I use Windows 10/11)? forgot it, it is being used in the CI workflow arggg |
Thanks for the heads-up! 💚 I've noticed it and am already working on the upgrade in a separate branch. I'll submit a PR once it's ready. |
rolldown-viterolldown-vite
| optimizeDeps: { | ||
| exclude: [ | ||
| '@vueuse/shared', | ||
| '@vueuse/core', | ||
| 'body-scroll-lock', | ||
| '@vue/repl', | ||
| ], | ||
| include: [ | ||
| 'axios', | ||
| 'yaml', | ||
| 'nprogress', | ||
| 'qrcode', | ||
| 'tslib', | ||
| 'fuse.js', | ||
| 'universal-cookie', | ||
| ], | ||
| disabled: 'dev', | ||
| noDiscovery: true, | ||
| }, |
There was a problem hiding this comment.
Please note: optimizeDeps.disabled has been deprecated, so I've modified this section accordingly. I'm not entirely sure if the change is correct, so I'd appreciate it if you could pay extra attention during review.
Here is the documentation: https://vite.dev/config/dep-optimization-options.html#optimizedeps-disabled
There was a problem hiding this comment.
doesn't this mean we should still have include?
it sounds like noDiscovery just means anything not inside include will not automatically be optimised during dev
so we could still populate include and get rid of exclude maybe?
There was a problem hiding this comment.
IMO, we previously had optimizeDeps.disabled: 'dev', which meant the configuration only took effect during build. However, since Vite 5.1, Vite no longer performs the optimization during build, meaning we now need to disable this feature entirely.
BTW, I also referenced isDepOptimizationDisabled in Vite.
# Conflicts: # pnpm-lock.yaml # pnpm-workspace.yaml
Before submitting the PR, please make sure you do the following
fixes #123).Description
This PR replaces
vitewithrolldown-vitein the whole repo.Additional context
#5137 (comment)
Thanks @brc-dd