feat: abi method factory#260
Open
bout3fiddy wants to merge 5 commits into
Open
Conversation
Member
|
this seems like a bit of a niche use case. i think it might be more generally useful for users if the function were |
Member
|
also, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Enables:
This way, I don't need to store a long abi file, or write a complicated json dict and let vyper handle it for me underneath.
How I did it
Added method
from_fn_sigto ABIContractFactory class, thus extending it's scope to beyond just providing a list of dict.How to verify it
Run test: https://github.com/bout3fiddy/titanoboa/blob/ac38a8b79a2467b8c68bbe42b38fd21e072a1caa/tests/integration/fork/test_abi_contract.py#L43
Description for the changelog
Adds
boa.loads_fn_sig("def foo() -> uint256: view")-> contract object.Cute Animal Picture